From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-59321-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22675 invoked by alias); 17 Oct 2008 17:28:25 -0000
Received: (qmail 22667 invoked by uid 22791); 17 Oct 2008 17:28:25 -0000
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 17 Oct 2008 17:27:47 +0000
Received: from mailhost5.vmware.com (mailhost5.vmware.com [10.16.68.131]) 	by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 0D8181A00B; 	Fri, 17 Oct 2008 10:27:44 -0700 (PDT)
Received: from [10.20.92.59] (promb-2s-dhcp59.eng.vmware.com [10.20.92.59]) 	by mailhost5.vmware.com (Postfix) with ESMTP id 053E5DC058; 	Fri, 17 Oct 2008 10:27:44 -0700 (PDT)
Message-ID: <48F8CA2C.2070903@vmware.com>
Date: Fri, 17 Oct 2008 17:28:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 1.5.0.12 (X11/20080411)
MIME-Version: 1.0
To: teawater <teawater@gmail.com>
CC: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [reverse RFA] Remove process record warning code
References: <daef60380810170057l56803830nf79e6d6befa7f3cc@mail.gmail.com>
In-Reply-To: <daef60380810170057l56803830nf79e6d6befa7f3cc@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-10/txt/msg00437.txt.bz2


You don't think you need this special warning?

teawater wrote:
> Hi Michael,
> 
> 2008-10-17  Hui Zhu  <teawater@gmail.com>
> 
>         * infcmd.c (kill_if_already_running): Remove process record
>         warning code.
> 
> Thanks,
> Hui
> 
> 
> ------------------------------------------------------------------------
> 
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2008-10-17  Hui Zhu  <teawater@gmail.com>
> +
> +	* infcmd.c (kill_if_already_running): Remove process record
> +	warning code.
> +
>  2008-10-15  Hui Zhu  <teawater@gmail.com>
>  
>  	Change "record-auto-delete" to "record-stop-at-limit".
> --- a/infcmd.c
> +++ b/infcmd.c
> @@ -51,7 +51,6 @@
>  #include "exceptions.h"
>  #include "cli/cli-decode.h"
>  #include "gdbthread.h"
> -#include "record.h"
>  
>  /* Functions exported for general use, in inferior.h: */
>  
> @@ -427,12 +426,8 @@ kill_if_already_running (int from_tty)
>  	 restart it.  */
>        target_require_runnable ();
>  
> -      if (from_tty)
> -	if (!query (RECORD_IS_USED ?
> -		    "The program being debugged has been started already,\n\
> -and is running in record/replay mode.  Do you want to abandon\n\
> -the recording and start the program from the beginning? " :
> -		    "The program being debugged has been started already.\n\
> +      if (from_tty
> +	  && !query ("The program being debugged has been started already.\n\
>  Start it from the beginning? "))
>  	  error (_("Program not restarted."));
>        target_kill ();