From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19220 invoked by alias); 10 Oct 2008 17:44:09 -0000 Received: (qmail 19211 invoked by uid 22791); 10 Oct 2008 17:44:08 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 10 Oct 2008 17:43:26 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id B9E8B37006 for ; Fri, 10 Oct 2008 10:43:24 -0700 (PDT) Received: from [10.20.92.59] (promb-2s-dhcp59.eng.vmware.com [10.20.92.59]) by mailhost3.vmware.com (Postfix) with ESMTP id AAB8AC9A84; Fri, 10 Oct 2008 10:43:24 -0700 (PDT) Message-ID: <48EF93A5.7060808@vmware.com> Date: Fri, 10 Oct 2008 17:44:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Michael Snyder CC: "gdb-patches@sourceware.org" Subject: Re: [RFA] Resubmit, reverse debugging [0/5] References: <48EC1781.2030005@vmware.com> In-Reply-To: <48EC1781.2030005@vmware.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00325.txt.bz2 Has the discussion converged? Wait until Monday and then commit? Michael Snyder wrote: > OK, after incorporating various review suggestions, > this patch supercedes the patch of 10/01/2008. > > The following change log entries are not part of the patch, > but are provided to show what has changed since last time, > mostly in response to review suggestions. > > > 2008-10-07 Michael Snyder > > * target.h (to_set_exec_direction, to_get_exec_direction): Remove. > (to_can_execute_reverse): New method. > (enum exec_direction_kind): Move to inferior.h. > * target.c (update_current_target): Inherit to_can_execute_reverse. > Remove to_set_exec_direction, to_get_exec_direction. > * inferior.h (enum exec_direction_kind): Move from target.h. > > * infrun.c (set_exec_direction_func): Move here from reverse.c. > (show_exec_direction_func): Ditto. > (proceed): Consult global execution_direction instead of > target method. > (handle_inferior_event): Ditto. > > * reverse.c (set_exec_direction_func): Move to infrun.c > (show_exec_direction_func): Ditto. > (exec_direction_default): Set infrun global variable. > (exec_reverse_once): Consult infrun global direction variable. > > * infcmd.c (step_1): Consult infrun global direction variable. > (step_once): Ditto. > (until_next_command): Ditto. > (finish_command): Ditto. > > * record.h (record_exec_direction): Delete. > (RECORD_IS_REPLAY): Consult infrun global direction variable. > > * record.c: (record_wait_cleanups): Use infrun state variable. > (record_wait): Ditto. > (record_get_exec_direction, record_set_exec_direction): Remove. > (record_can_execute_reverse): New target method. > > * remote.c (remote_resume): Use infrun state variable. > (remote_get_exec_direction, remote_set_exec_direction): Remove. > (remote_can_execute_reverse): New target method. > > 2008-10-07 Michael Snyder > > * infrun.c (stepped_into_function): Rename > handle_step_into_function. > (stepped_into_function_backward): > Rename handle_step_into_function_backward. > > * reverse.c: Update copyright. > (exec_reverse_once): Add function header comment. > (_initialize_reverse): Use i18n macros for set exec-direction. > 2008-10-06 Michael Snyder > > * breakpoint.c (breakpoint_silence): Rename to > make_breakpoint_silent. > * breakpoint.h: Ditto. > * infcmd.c (finish_backward): Call make_breakpoint_silent > instead of breakpoint_silence. > > * infcmd.c (finish_command): Reject async in reverse. > * infcmd.c (finish_command): Use i18n macros. > * infcmd.c: Minor function reordering. > * infrun.c (step_into_function): Rename to stepped_into_function. > Split into two versions (normal (forward), and reverse). > (handle_inferior_event): Call stepped_into_function or > stepped_into_function_backward, depending on exec_direction. > * infrun.c (handle_inferior_event): Comment rewording. > * remote.c (remote_get_exec_direction): Use i18n macros. > (remote_set_exec_direction): Ditto. > * infrun.c (handle_inferior_event, step_into_function): Formatting. > * infrun.c (handle_inferior_event): Formatting, spelling fix. > > * infrun.c (handle_inferior_event): Add special case for > "next" in reverse. > 2008-10-05 Michael Snyder > > * reverse.c (exec_reverse_once): Call do_cleanups explicitly. > * infrun.c (handle_inferior_event): Fix typo in comment. > > 2008-10-04 Michael Snyder > > * target.c, target.h: Rename execdir to exec_direction. > * record.c, record.h: Ditto. > * reverse.c: Ditto. > * remote.c: Ditto. > > * reverse.c (show_exec_direction_func): Don't error, just inform. > > * reverse.c (reverse-continue): Remove a comma from docs string, > to avoid confusing output from 'apropos'. > > >