From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20760 invoked by alias); 5 Oct 2008 20:35:27 -0000 Received: (qmail 20749 invoked by uid 22791); 5 Oct 2008 20:35:26 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 05 Oct 2008 20:34:51 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id C19515B00A; Sun, 5 Oct 2008 13:34:49 -0700 (PDT) Received: from [10.20.92.59] (promb-2s-dhcp59.eng.vmware.com [10.20.92.59]) by mailhost4.vmware.com (Postfix) with ESMTP id 86243C9A35; Sun, 5 Oct 2008 13:34:49 -0700 (PDT) Message-ID: <48E92487.1@vmware.com> Date: Sun, 05 Oct 2008 20:35:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Eli Zaretskii CC: "mark@klomp.org" , "mark.kettenis@xs4all.nl" , "gdb-patches@sourceware.org" , "teawater@gmail.com" Subject: Re: [RFA record/replay] cast to avoid compiler warning References: <48E7B927.9050207@vmware.com> <09B97D2C4B49DF409E2D018999AC6FE115B42A89C4@PA-EXMBX14.vmware.com> <20081005160411.GA29968@caradoc.them.org> <48E906B5.8070600@vmware.com> In-Reply-To: Content-Type: multipart/mixed; boundary="------------050105000404080208030906" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00140.txt.bz2 This is a multi-part message in MIME format. --------------050105000404080208030906 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 298 Eli Zaretskii wrote: >> Date: Sun, 05 Oct 2008 11:25:57 -0700 >> From: Michael Snyder >> >> OK. So, would you favor using the "%zd" modifier instead of a cast? > > What's wrong with casting to "unsigned long" and using %lu? I know when to give up! ;-) Like this, then: --------------050105000404080208030906 Content-Type: text/plain; name="sizeof.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="sizeof.txt" Content-length: 6387 2008-10-03 Michael Snyder * linux-record.c (record_linux_system_call): Cast sizeof in printf calls, avoid compiler warnings on 64 bit hosts. Index: linux-record.c =================================================================== RCS file: /cvs/src/src/gdb/Attic/linux-record.c,v retrieving revision 1.1.2.4 diff -u -p -r1.1.2.4 linux-record.c --- linux-record.c 7 Sep 2008 01:40:43 -0000 1.1.2.4 +++ linux-record.c 5 Oct 2008 20:33:21 -0000 @@ -596,8 +596,8 @@ record_linux_system_call (int num, linux if (target_read_memory (tmpu32, (gdb_byte *) & sel, sizeof (sel))) { fprintf_unfiltered (gdb_stdlog, - "Record: read memory addr = 0x%s len = %d error.\n", - paddr_nz (tmpu32), sizeof (sel)); + "Record: read memory addr = 0x%s len = %lu error.\n", + paddr_nz (tmpu32), (unsigned long) sizeof (sel)); return (-1); } if (record_arch_list_add_mem (sel.inp, tdep->size_fd_set)) @@ -748,8 +748,8 @@ record_linux_system_call (int num, linux if (target_read_memory (tmpu32, (gdb_byte *) a, sizeof (a))) { fprintf_unfiltered (gdb_stdlog, - "Record: read memory addr = 0x%s len = %d error.\n", - paddr_nz (tmpu32), sizeof (a)); + "Record: read memory addr = 0x%s len = %lu error.\n", + paddr_nz (tmpu32), (unsigned long) sizeof (a)); return (-1); } if (record_arch_list_add_mem (a[1], tdep->size_sockaddr)) @@ -774,8 +774,8 @@ record_linux_system_call (int num, linux if (target_read_memory (tmpu32, (gdb_byte *) a, sizeof (a))) { fprintf_unfiltered (gdb_stdlog, - "Record: read memory addr = 0x%s len = %d error.\n", - paddr_nz (tmpu32), sizeof (a)); + "Record: read memory addr = 0x%s len = %lu error.\n", + paddr_nz (tmpu32), (unsigned long) sizeof (a)); return (-1); } if (record_arch_list_add_mem (a[3], tdep->size_int)) @@ -798,8 +798,8 @@ record_linux_system_call (int num, linux if (target_read_memory (tmpu32, (gdb_byte *) a, sizeof (a))) { fprintf_unfiltered (gdb_stdlog, - "Record: read memory addr = 0x%s len = %d error.\n", - paddr_nz (tmpu32), sizeof (a)); + "Record: read memory addr = 0x%s len = %lu error.\n", + paddr_nz (tmpu32), (unsigned long) sizeof (a)); return (-1); } if (a[2]) @@ -808,8 +808,8 @@ record_linux_system_call (int num, linux (a[2], (gdb_byte *) & (a[2]), sizeof (a[2]))) { fprintf_unfiltered (gdb_stdlog, - "Record: read memory addr = 0x%s len = %d error.\n", - paddr_nz (a[2]), sizeof (a[2])); + "Record: read memory addr = 0x%s len = %lu error.\n", + paddr_nz (a[2]), (unsigned long) sizeof (a[2])); return (-1); } if (record_arch_list_add_mem (a[1], a[2])) @@ -830,8 +830,8 @@ record_linux_system_call (int num, linux if (target_read_memory (tmpu32, (gdb_byte *) a, sizeof (a))) { fprintf_unfiltered (gdb_stdlog, - "Record: read memory addr = 0x%s len = %d error.\n", - paddr_nz (tmpu32), sizeof (a)); + "Record: read memory addr = 0x%s len = %lu error.\n", + paddr_nz (tmpu32), (unsigned long) sizeof (a)); return (-1); } if (a[2]) @@ -840,8 +840,8 @@ record_linux_system_call (int num, linux (a[2], (gdb_byte *) & (a[2]), sizeof (a[2]))) { fprintf_unfiltered (gdb_stdlog, - "Record: read memory addr = 0x%s len = %d error.\n", - paddr_nz (a[2]), sizeof (a[2])); + "Record: read memory addr = 0x%s len = %lu error.\n", + paddr_nz (a[2]), (unsigned long) sizeof (a[2])); return (-1); } if (record_arch_list_add_mem (a[1], a[2])) @@ -875,8 +875,8 @@ record_linux_system_call (int num, linux if (target_read_memory (tmpu32, (gdb_byte *) a, sizeof (a))) { fprintf_unfiltered (gdb_stdlog, - "Record: read memory addr = 0x%s len = %d error.\n", - paddr_nz (tmpu32), sizeof (a)); + "Record: read memory addr = 0x%s len = %lu error.\n", + paddr_nz (tmpu32), (unsigned long) sizeof (a)); return (-1); } if (a[4]) @@ -885,8 +885,8 @@ record_linux_system_call (int num, linux (a[4], (gdb_byte *) & av, sizeof (av))) { fprintf_unfiltered (gdb_stdlog, - "Record: read memory addr = 0x%s len = %d error.\n", - paddr_nz (a[4]), sizeof (av)); + "Record: read memory addr = 0x%s len = %lu error.\n", + paddr_nz (a[4]), (unsigned long) sizeof (av)); return (-1); } if (record_arch_list_add_mem (a[3], av)) @@ -929,8 +929,8 @@ record_linux_system_call (int num, linux if (target_read_memory (tmpu32, (gdb_byte *) a, sizeof (a))) { fprintf_unfiltered (gdb_stdlog, - "Record: read memory addr = 0x%s len = %d error.\n", - paddr_nz (tmpu32), sizeof (a)); + "Record: read memory addr = 0x%s len = %lu error.\n", + paddr_nz (tmpu32), (unsigned long) sizeof (a)); return (-1); } if (record_arch_list_add_mem (a[1], tdep->size_msghdr)) @@ -943,8 +943,8 @@ record_linux_system_call (int num, linux (a[1], (gdb_byte *) & rec, sizeof (rec))) { fprintf_unfiltered (gdb_stdlog, - "Record: read memory addr = 0x%s len = %d error.\n", - paddr_nz (a[1]), sizeof (rec)); + "Record: read memory addr = 0x%s len = %lu error.\n", + paddr_nz (a[1]), (unsigned long) sizeof (rec)); return (-1); } if (record_arch_list_add_mem @@ -966,9 +966,9 @@ record_linux_system_call (int num, linux sizeof (iov))) { fprintf_unfiltered (gdb_stdlog, - "Record: read memory addr = 0x%s len = %d error.\n", + "Record: read memory addr = 0x%s len = %lu error.\n", paddr_nz (rec.msg_iov), - sizeof (iov)); + (unsigned long) sizeof (iov)); return (-1); } if (record_arch_list_add_mem @@ -1334,9 +1334,9 @@ record_linux_system_call (int num, linux (vec, (gdb_byte *) & iov, sizeof (struct record_iovec))) { fprintf_unfiltered (gdb_stdlog, - "Record: read memory addr = 0x%s len = %d error.\n", + "Record: read memory addr = 0x%s len = %lu error.\n", paddr_nz (vec), - sizeof (struct record_iovec)); + (unsigned long) sizeof (struct record_iovec)); return (-1); } if (record_arch_list_add_mem (iov.iov_base, iov.iov_len)) --------------050105000404080208030906--