From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26042 invoked by alias); 8 Sep 2008 15:36:55 -0000 Received: (qmail 26033 invoked by uid 22791); 8 Sep 2008 15:36:54 -0000 X-Spam-Check-By: sourceware.org Received: from smtp1.dnsmadeeasy.com (HELO smtp1.dnsmadeeasy.com) (205.234.170.134) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 08 Sep 2008 15:36:15 +0000 Received: from smtp1.dnsmadeeasy.com (localhost [127.0.0.1]) by smtp1.dnsmadeeasy.com (Postfix) with ESMTP id D4716320B85; Mon, 8 Sep 2008 15:36:22 +0000 (UTC) X-Authenticated-Name: js.dnsmadeeasy X-Transit-System: In case of SPAM please contact abuse@dnsmadeeasy.com Received: from avtrex.com (unknown [173.8.135.205]) by smtp1.dnsmadeeasy.com (Postfix) with ESMTP; Mon, 8 Sep 2008 15:36:22 +0000 (UTC) Received: from silver64.hq2.avtrex.com ([192.168.7.15]) by avtrex.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 8 Sep 2008 08:36:10 -0700 Message-ID: <48C5466D.6090906@avtrex.com> Date: Mon, 08 Sep 2008 15:36:00 -0000 From: David Daney User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [Patch] Fix 'incomplete type' warning in dummy_frame.h References: <200809081123.m88BNHHT030564@d12av02.megacenter.de.ibm.com> In-Reply-To: <200809081123.m88BNHHT030564@d12av02.megacenter.de.ibm.com> Content-Type: multipart/mixed; boundary="------------000704070607030808000802" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00165.txt.bz2 This is a multi-part message in MIME format. --------------000704070607030808000802 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 1085 Ulrich Weigand wrote: > David Daney wrote: > >> Back on 2008-08-26, Ulrich Weigand added a declaration for >> dummy_frame_pop to dummy_frame.h. This causes a fatal warning when I >> build with gcc-3.4 targeting mipsel-linux-gnu because struct frame_id is >> an incomplete type. >> >> Adding #include "frame.h" fixes the problem for me. > > Huh. Sorry for the breakage. Strange that this compiles without even > a warning with GCC 4.1.1 ... I think it may depend on the ABI. The calling convention for passing a struct can vary depending on the size of the struct. > >> I'm don'e think I have write access to gdb (I do have it in binutils), >> so if it is OK, someone will either have to commit it or turn on write >> access for me. > > If you have access to binutils, you should also have access in GDB, > as both actually reside in the same src repository. > You are correct. I added a new line after the #include and committed this version: 2008-09-08 David Daney * dummy-frame.h (frame.h): Include it. (struct frame_id): Remove declaration. --------------000704070607030808000802 Content-Type: text/plain; name="dummy_frame.h.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="dummy_frame.h.patch" Content-length: 574 Index: dummy-frame.h =================================================================== RCS file: /cvs/src/src/gdb/dummy-frame.h,v retrieving revision 1.22 diff -u -p -r1.22 dummy-frame.h --- dummy-frame.h 26 Aug 2008 17:40:24 -0000 1.22 +++ dummy-frame.h 8 Sep 2008 15:21:35 -0000 @@ -20,10 +20,11 @@ #if !defined (DUMMY_FRAME_H) #define DUMMY_FRAME_H 1 +#include "frame.h" + struct frame_info; struct regcache; struct frame_unwind; -struct frame_id; /* Push the information needed to identify, and unwind from, a dummy frame onto the dummy frame stack. */ --------------000704070607030808000802--