Ulrich Weigand wrote:
> David Daney wrote:
> 
>> Back on 2008-08-26, Ulrich Weigand added a declaration for
>> dummy_frame_pop to dummy_frame.h.  This causes a fatal warning when I
>> build with gcc-3.4 targeting mipsel-linux-gnu because struct frame_id is
>> an incomplete type.
>>
>> Adding #include "frame.h" fixes the problem for me.
> 
> Huh.  Sorry for the breakage.  Strange that this compiles without even
> a warning with GCC 4.1.1 ...

I think it may depend on the ABI.  The calling convention for passing a
struct can vary depending on the size of the struct.

> 
>> I'm don'e think I have write access to gdb (I do have it in binutils),
>> so if it is OK, someone will either have to commit it or turn on write
>> access for me.
> 
> If you have access to binutils, you should also have access in GDB, 
> as both actually reside in the same src repository.
> 

You are correct.  I added a new line after the #include and committed
this version:

2008-09-08  David Daney  <ddaney@avtrex.com>

	* dummy-frame.h (frame.h): Include it.
	(struct frame_id): Remove declaration.