Joel Brobecker wrote:
> 
> 
> Moving the code to a function is a great idea.  I suggest to move
> that function just before the function where you use it. That way,
> you don't have to add this advance declaration here.

Done.

> 
> Also I suggest we change the name a bit. For instance:
>   - bp_loc_is_permanent, or
      ^^^^^^^^^^^^^^^^^^^ accepted
>   - permanent_bp_loc
> 

> 
> The description doesn't explain what the function does if the location
> is pointing to a permanent breakpoint.  I suggest the following:
> 

Done.
> /* Return non-zero if LOC is pointing to a permanent breakpoint.  */

> 
> Again, I find the "$pattern_matched" confusing. I'd prefer it if you compared
> directly against litteral 0.
Done.
> Also, I don't completely understand the ".1" part of your regexp. And
> the gdb_test_multiple documentation also says that you should include
> the final newline and prompt. So I suggest:
> 
>   -re ".*($hex).*$gdb_prompt $".
It was a shortcut for "\\\$1". 
Changed.
> 
> 



Attached revised patches.

Thanks,

Aleksandar Ristovski
QNX Software Systems