From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1484 invoked by alias); 28 Aug 2008 18:13:40 -0000 Received: (qmail 1466 invoked by uid 22791); 28 Aug 2008 18:13:39 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.113.40.141) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 28 Aug 2008 18:13:04 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.64.160]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 8A6D96870 for ; Thu, 28 Aug 2008 11:13:00 -0700 (PDT) Received: from [10.20.92.47] (unknown [10.20.92.47]) by mailhost2.vmware.com (Postfix) with ESMTP id 7F8CD8E5BF for ; Thu, 28 Aug 2008 11:13:00 -0700 (PDT) Message-ID: <48B6E9F4.5080403@vmware.com> Date: Thu, 28 Aug 2008 18:13:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: RFC: Do not call write_pc for "signal SIGINT" References: <20080828155520.GA23110@caradoc.them.org> In-Reply-To: <20080828155520.GA23110@caradoc.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00652.txt.bz2 Daniel Jacobowitz wrote: > This FIXME has been there since the dawn of CVS. Removing it causes > no testsuite regressions on x86_64-linux; I don't think it will on > other platforms either. > > Any comments on this patch? Otherwise I'll check it in after a little > while. Hmmm, kind of opaque. Your new code seems like the right thing to do, but I don't understand the code that you're replacing. Isn't -1 supposed to mean the same as stop_pc? And isn't signal 0 equivalent to no signal? > This isn't the only place where Linux's internal errno codes can leak > back into user programs because of how we fiddle orig_eax. I'll file > another bug report about that. Now you've really lost me. What have errno codes got to do with this? > 2008-08-28 Daniel Jacobowitz > > PR gdb/2241 > * infcmd.c (signal_command): Do not specify a resume PC. > > Index: infcmd.c > =================================================================== > RCS file: /cvs/src/src/gdb/infcmd.c,v > retrieving revision 1.200 > diff -u -p -r1.200 infcmd.c > --- infcmd.c 21 Aug 2008 20:13:08 -0000 1.200 > +++ infcmd.c 28 Aug 2008 15:51:15 -0000 > @@ -1123,11 +1123,7 @@ signal_command (char *signum_exp, int fr > } > > clear_proceed_status (); > - /* "signal 0" should not get stuck if we are stopped at a breakpoint. > - FIXME: Neither should "signal foo" but when I tried passing > - (CORE_ADDR)-1 unconditionally I got a testsuite failure which I haven't > - tried to track down yet. */ > - proceed (oursig == TARGET_SIGNAL_0 ? (CORE_ADDR) -1 : stop_pc, oursig, 0); > + proceed ((CORE_ADDR) -1, oursig, 0); > } > > /* Proceed until we reach a different source line with pc greater than