From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by sourceware.org (Postfix) with ESMTPS id 93C1A385E011 for ; Thu, 2 Apr 2020 19:24:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 93C1A385E011 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1585855434; bh=FwbhUIzLlh8dq1Ntj7MkWs7ZixYvhG9lStRMjrB5Lq0=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=ZVIWYEYuQRXKQ1P6zBKdZ72aUnGWX6oS52wQ729n/D7GlciVLcNeVE+R0Cidu5r5A yVhWKHMG3gULUCoZ8kYvfzrNE8dN3NVIKoUVD47dPOWJWxH/PL362ZmQJuwNqg7HKv eQeLf/U3NZmu+W17KwmaCQqQHkwPTZU13b9D4FVk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MbzuH-1ilqLt33Al-00dSXd; Thu, 02 Apr 2020 21:23:54 +0200 Subject: Re: [PATCH v4] Implement basic threading support in the NetBSD target To: Pedro Alves , gdb-patches@sourceware.org Cc: tom@tromey.com References: <20200401210139.27152-1-n54@gmx.com> <20200401213321.20107-1-n54@gmx.com> <04ae24e8-3496-a8bb-908d-6f1a2e2f98f5@redhat.com> From: Kamil Rytarowski Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Message-ID: <4884140c-867a-a0a7-bf03-ff0bc64c8028@gmx.com> Date: Thu, 2 Apr 2020 21:22:46 +0200 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <04ae24e8-3496-a8bb-908d-6f1a2e2f98f5@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:jTQfa8eWVTX3cb8A+I13JNu3KYFv15XZm9X3FPaFPsvQBXVeI4N cOGogYOFL+Oj/sj6U4kDvbfc1LQy983/KqnR45ILwEEAGeowkOB5m6S87d10k5iSb0d23tW K8CveNoBTL8EzNeB8MjOTNV7M8dYcRfUuaWdcRQvbDRPyI2a42ty9XgMGu89b93yw8Z5A9f oxOp7Y5jhLabJJ1b7F8vw== X-UI-Out-Filterresults: notjunk:1;V03:K0:844e3ONtYrI=:wNHyvVI4lDRbpKLwOIElxG kPBEmZfhNSkkpMkdd1rW/51DLtZ31H1COgMAL9rkpzl/LKoAraLXRo3SYUfSkYh7YtDXO7Pti 8z7a6cdAxXRcuXHl7qW1Q/hlGe19DH7WBxuIhkfcotHlf5l1UBHTs3cj/Kw3ZmyTCbEM3m7zI KJNZEhhzuTMnGmqmrKzlvIrYggvwbwW+HFB0fnj8l12I3uzYBxmlTrQcH2GJOa/BmjJ0vl1xV QWUEgIvb1XEqFzzAetqVMRtQYh+jl0oq/eBygcqZWQRulu76GZn42+EIdWUWfDiA6oeljmj0v sh0HMGvCyRvP/5SLH4RJAbzJjnuHI9627Sxg6vTX2XNGkeXlSkggDuKOVVSyqPwZGDqEDMXHm bqTzuBK8s5915sUgsYIFBW9D8abVeBDCxhEJkHVi6f0514s7xdK/wDx9A8p5EZEP2tYXTxIos 7nHQiIvqRcr69m1aQWl0R0JaJNdB43SYbLdHtwE/yln7q3y2Xj6nJ6XyndBpwoEC3BC6FfUjv ChWWOeYQXboYnVv34kSpLvLPleegy2E2H86N5sSvXD11koJVLurOHGHRK+2RsQMj4I0euG17v VaE5q2aArNZ78TNrq9wg1IDHGWUEPj+SfRkpt0oAnlonzwS8kB5FYWIykrwryVNiXYFe3wly5 FyadjlolFyKbTvpik49ev2CjVJWa3V3DxKhaFbQcvO0OCpBCMXw7YLqUSYWywuArZ9fZgBzBt QO6HU3QaF4kpqdJVsyBde9MWQ+FFFKFkHKDd/Q8+Q4M1WPB+I9IQYoxdr1JverIkQgO5iSRA9 Glxx0cCUOKzkZ+wXD9YObxNIWPJn9bXDi0nT2+lY4duy0Ckv3aR5RKvA5B/q6ji5WKZg+YfAs FlC1IvgZ+DeKQ+MV+cFu8ZOlh5SK162xJM5NkjSiwMqhQl05cRsozbhidgeKiHRzqTP4fKlPy 4Oal5ITPqIR+e7cQo9KRDJCNSyYe9m4C8p50QSPprgrE49bfIfOa0FZnXZq68tOlDkfuy9aRa Azmq+bIm74j1faVX8kpQdYeUdVd30kwLU8GO4+GPtcBcQj8RmzLylhEK1+V66JyZNRCaj551s EAPPYuKGxG7buxyWOQuL956pcmY0s2/jGh0UGyr/Vx7BdOleXDTcH8nIlqGV5zvg/IuOx7led YX4HKHwKXx4sKwVuOvMTH8gAbGLtIp+E4ee5OdhvoKC3NS7ReHnBtWqntMO1tpFSvRpBI= X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Apr 2020 19:24:12 -0000 On 02.04.2020 21:05, Pedro Alves wrote: > Hi, > > I skimmed the patch and noticed a couple nits. > > On 4/1/20 10:33 PM, Kamil Rytarowski wrote: > >> +static bool >> +nbsd_thread_lister (const pid_t pid, >> + gdb::function_view >> + callback) >> +{ >> + int mib[5] =3D {CTL_KERN, KERN_LWP, pid, sizeof (struct kinfo_lwp), = 0}; >> + size_t size; >> + >> + if (sysctl (mib, ARRAY_SIZE (mib), NULL, &size, NULL, 0) =3D=3D -1 |= | size =3D=3D 0) >> + perror_with_name (("sysctl")); >> + >> + mib[4] =3D size / sizeof (size_t); >> + >> + gdb::unique_xmalloc_ptr kl > > You can use the array variant: > > gdb::unique_xmalloc_ptr > Done. >> + ((struct kinfo_lwp *) xcalloc (size, 1)); >> + if (kl =3D=3D NULL) >> + perror_with_name (("calloc")); > > xcalloc doesn't ever return NULL. > Done. >> + >> + if (sysctl (mib, ARRAY_SIZE (mib), kl.get (), &size, NULL, 0) =3D=3D= -1 >> + || size =3D=3D 0) >> + perror_with_name (("sysctl")); >> + >> + for (size_t i =3D 0; i < size / sizeof (struct kinfo_lwp); i++) >> + { >> + struct kinfo_lwp *l =3D &kl.get ()[i]; > > If you use the array variant, then here you don't need the .get(), like: > > struct kinfo_lwp *l =3D &kl[i]; > Done. > Thanks, > Pedro Alves > Please see v5.