From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17334 invoked by alias); 11 Jul 2008 08:52:11 -0000 Received: (qmail 17322 invoked by uid 22791); 11 Jul 2008 08:52:10 -0000 X-Spam-Check-By: sourceware.org Received: from mail4.nsc.com (HELO sc-mailgw02.nsc.com) (12.151.32.19) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 11 Jul 2008 08:51:41 +0000 X-WSS-ID: 0K3U3A1-0A-0QX-01 Received: from SCNTRDCSS8.nsc.com (unknown [192.168.7.27]) by sc-mailgw02.nsc.com (Tumbleweed MailGate 3.5.1) with ESMTP id 211E21236CF2 for ; Fri, 11 Jul 2008 01:51:36 -0700 (PDT) Received: from [10.188.132.130] by SCNTRDCSS6.nsc.com with ESMTP (-Hi-); Fri, 11 Jul 2008 01:51:33 -0700 X-Server-Uuid: CDE0D3F6-4EC6-4DC9-81EF-DBBF12AF9A3C Received: from [139.187.78.152] by scmh1.nsc.com with ESMTP; Fri, 11 Jul 2008 01:51:32 -0700 Message-ID: <48771F5F.6090102@nsc.com> Date: Fri, 11 Jul 2008 08:52:00 -0000 From: "M R Swami Reddy" User-Agent: Thunderbird 2.0.0.14 (Windows/20080421) MIME-Version: 1.0 To: "Hans-Peter Nilsson" cc: gdb-patches@sourceware.org Subject: Re: Committed: fix sim/cr16/interp.c hash prototype References: <200807110135.m6B1ZRxp032164@ignucius.se.axis.com> In-Reply-To: <200807110135.m6B1ZRxp032164@ignucius.se.axis.com> X-WSS-ID: 6469C09F1942837996-01-01 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00182.txt.bz2 Hello Hans-Peter Nilsson, This patch seems ok. Could you please apply? Thanks, Swami Hans-Peter Nilsson wrote: > While cleaning up the recently introduced -lz mess in sim, I > found that the cr16 sim didn't compile for me (gcc-4.0.2-8.fc4): > > gcc -c -DHAVE_CONFIG_H -DPROFILE=1 -DWITH_PROFILE=-1 -DDEFAULT_INLINE=0 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitialized -DNEED_UI_LOOP_HOOK -DSIM_HAVE_ENVIRONMENT -I. -I/home/hp/combined/sim_write/src/sim/cr16 -I../common -I/home/hp/combined/sim_write/src/sim/cr16/../common -I../../include -I/home/hp/combined/sim_write/src/sim/cr16/../../include -I../../bfd -I/home/hp/combined/sim_write/src/sim/cr16/../../bfd -I../../opcodes -I/home/hp/combined/sim_write/src/sim/cr16/../../opcodes -g -O2 /home/hp/combined/sim_write/src/sim/cr16/interp.c > x/src/sim/cr16/interp.c:96: error: conflicting types for `hash' > x/src/sim/cr16/interp.c:53: error: previous declaration of `hash' here > x/src/sim/cr16/interp.c: In function `do_run': > x/src/sim/cr16/interp.c:400: warning: comparison between pointer and integer > make[3]: *** [interp.o] Error 1 > > As the prototype isn't required, I fixed it thus, committed: > > sim/cr16: > * interp.c (hash): Remove incorrect prototype. > > Index: interp.c > =================================================================== > RCS file: /cvs/src/src/sim/cr16/interp.c,v > retrieving revision 1.2 > diff -p -u -r1.2 interp.c > --- interp.c 5 May 2008 09:19:42 -0000 1.2 > +++ interp.c 11 Jul 2008 01:29:02 -0000 > @@ -50,7 +50,6 @@ asection *text; > bfd_vma text_start; > bfd_vma text_end; > > -static long hash PARAMS ((uint64 linsn, int)); > static struct hash_entry *lookup_hash PARAMS ((uint64 ins, int size)); > static void get_operands PARAMS ((operand_desc *s, uint64 mcode, int isize, int nops)); > static int do_run PARAMS ((uint64 mc)); > > brgds, H-P >