Re: remote.c Z0 packet detection robustness

Daniel Jacobowitz
2008-06-27T18:22:46Z

On Fri, Jun 27, 2008 at 07:17:25PM +0100, Jonathan Larmour wrote:
> Daniel Jacobowitz wrote:
> > On Fri, Jun 27, 2008 at 04:55:37PM +0100, Jonathan Larmour wrote:
> >> 2008-06-27 Jonathan Larmour <jifl@eCosCentric.com>
> >>
> >> * remote.c (remote_insert_breakpoint): Ensure that if Z0
> >> unsupported and we fall back to memory_insert_breakpoint, we
> >> use the unmodified requested address.
> >
> > Thanks for the clear explanation. This is almost OK - but you need to
> > update bp_tgt if Z0 succeeds. Otherwise we may remove the breakpoint
> > incorrectly.
>
> Is this better?

Yes, this version is fine to commit. Thanks.

--
Daniel Jacobowitz
CodeSourcery