From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id H8ISIROWR2q5liMAWB0awg (envelope-from ) for ; Fri, 03 Jul 2026 06:59:31 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=xxC+FVtQ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 76ADA1E024; Fri, 03 Jul 2026 06:59:31 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E58711E024 for ; Fri, 03 Jul 2026 06:59:30 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7FAF44BA23D6 for ; Fri, 3 Jul 2026 10:59:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7FAF44BA23D6 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=xxC+FVtQ Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012020.outbound.protection.outlook.com [52.101.48.20]) by sourceware.org (Postfix) with ESMTPS id 292364BA5439 for ; Fri, 3 Jul 2026 10:59:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 292364BA5439 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 292364BA5439 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=52.101.48.20 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783076345; cv=pass; b=nO/G4/UUtIg7LIUWRjxaFKVh+Lau31L+eGFX5vYVNjBCDbYGhR979gGBhUxJKcc3zT+r/VYu64H1+uTxJdXn92lFgg96FJFMYq/oZA2Uzw733blgOwzEvxGvNghOUiEA3o31eTLpPPmvj8+t+i7v8amXprXCmZXmGScNiqxIkHY= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783076345; c=relaxed/simple; bh=r3F8eP9/1L/PuJ6Yb4GRqljdWxNZAfz4PmUVszSvVBU=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=V9m9Htix9ls6nXnEZgDkJqn7xnieOFrz/R1ITJ+jSkW8268xd7SKWuillu7JW8Hy9cbFPImp1VCql87lxs8dZ7ukxEmtC524Xcl0fU+rZiwTLVCbsSym2FdG1iPPU8XXbvD9R/7ta42aL2gcK93bouIVFoVhWu0VJmG66bSIrQ0= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=xxC+FVtQ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 292364BA5439 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=P4/qJpSuaGUcsRfw2qMytCgJlzqTjRUdL7XnkOgI2Qk08zMFnMuy3C3M3A2SeY0/OCnXOCNwX1dzBV2bo3GMRjA0U5PGYEroRKccGbmLEqiObw+AYa6LKRFmyLkwc131sfGOTJJzf5TFXN4vfKzcDjpkq6jaclsCIOIj0KRQNaeVRHnAsKc7uFaYBEAXewcdmMMPQvylcIlRMQGcRiMMC943cZMgszvbc1OvKSShe2QGVAHYzGOwRD4h9kGONMNHTn7bmD+6oFW5GDiabepblAA3yp03dOq8Ck6h02dG3WBHzb5FCL1qHHOcoINtUMIIL0gVYA5E7BX64HQxQxzj9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MKKirzs5H7XbOSk8JcjQ73r5YV7lQ0tF+GzZt2jN2wM=; b=FF54s0kmbFrTTZTEBwa8snTZaPUXIMjBs+rZ5qhWD8Qy+FpAt/3i0AmJQ8tnPDsKm8BNOFS9q2TOogk+eRD1JksTYYsj1HSzEqCDHOcDqGRajHA+fYvylp00i8LVWJA0L8/6ZSb70gsgE1iu6wb1/tKFem3lU0AJK+1siEyYGCgaQEz2aCr3sMdenk7ma79lxgNmOYoLxSFfpBcidedPAxQZigAqp6wKHF5BGuDtIByy2Ee0kVHC9wjVMMpW0CAK6Db2mtHr9PFFmDh3Ir4HCZnLHlCPEfMviDd2NyKNGa/cxPae2h24P5BvkMwiAHOmTZjahAlb7Cca/Iz1kNEucQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MKKirzs5H7XbOSk8JcjQ73r5YV7lQ0tF+GzZt2jN2wM=; b=xxC+FVtQ8AQxa1GbTuzQHJX9ye0RhW5q+ppRureK67Cl9a7EWt0LHo6iC0L95Sea5/BuI/o40KXHRetqx1PvR3P7ZPluPWFjl+Q+zLRiCPZjD2+QM3AguuexJ7w2wsvExmbRjqP30uKLzeNCrC/Im7fjwUs4rR4za9zADURDcJo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by PH0PR12MB8174.namprd12.prod.outlook.com (2603:10b6:510:298::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Fri, 3 Jul 2026 10:59:00 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::5a7a:2adf:1862:35c3]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::5a7a:2adf:1862:35c3%5]) with mapi id 15.21.0181.009; Fri, 3 Jul 2026 10:58:59 +0000 Message-ID: <48613917-c292-4198-ae3d-8f6dd2c59ff1@amd.com> Date: Fri, 3 Jul 2026 11:58:56 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: fix gdb.rocm/interrupt-twice To: "Aktemur, Baris" , "gdb-patches@sourceware.org" References: <20260701161855.646399-1-lancelot.six@amd.com> Content-Language: en-US From: Lancelot SIX In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0020.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::21) To CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9079:EE_|PH0PR12MB8174:EE_ X-MS-Office365-Filtering-Correlation-Id: f7102560-c922-476a-a994-08ded8f215f1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|366016|1800799024|376014|11063799006|4143699003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: MUpL+2l8fy0zJq3jr3pDpO3j30oTEf835nqc9LzaPBSfdbG1iGCzHfCl1YT3/64shFi92KiJgMltjENRzQFJcNbDJHRJV+mUHm4IU+k4tz1ssiLWHzFlJKgKREUbKPB8y13ufiia+6wNkPsbXmVBM2FLSLLXGZNkV9hqt47UkSLoj1/psQKAQMYqTr4eM2GGzZG5c8lUBQj+SZhA8aN8VqHzKTgKL1oBs8YlwmfEtCwL1oWsitFEopSgfTml/UDezD+Vf3lZyxuQuOu+RVZ0pRfrAqoAtqQWnBx7irbCFpdN9Q+qrclXonMPGFd1z4+/qHyPmzDM4qHkepbFxDE/QzPKqgOWmgPRlXcg1SwTg4UxZGPQGiSAYsycb4nBHsTDi14itbCV/nn7ffMN48b2h0cN3pPqoE/VkRZ6yJANsUfljh+vFFHBuw8PiLBcUT5eF0RWRy9Ff29M7NfJKDgDmlF4oSzJPRf4roGvWWM8/2FX0i8jCCute10QgC7wPLmG3JX+AWlWSSiKLlsIE5WfOSk4KKgd+++kgTRQYN4fTJA9K1mOMuWmt2W/Aqfg4plJXi4YH87rdmdEGcyEv77/2DQIRMSQtcmFLSdorQDDwUA25A4s/jd0AMf3Q0dPZbRZ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB9079.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(366016)(1800799024)(376014)(11063799006)(4143699003)(56012099006)(22082099003)(18002099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlBHVWUxa1VFR2ZVTWpVQWNBeU5aNjR5a1ZYc2xNZk9nZStQTHpJcWw3bHJS?= =?utf-8?B?VmJ3alNYL2tPdXV4TTRFU1V6RWNRZk1Ga2ZDaC95emJLc0JkMW85bXU3c2ky?= =?utf-8?B?a3Z1K0xlazRBSTBpbk45SzFiK09QZ01wQlh0WHAwakxYVjQrL3V1NWZzN1RK?= =?utf-8?B?dzJuT3FlYUtwNG10OHJMM0Q2M2VCdHE5cC9WdzgzakYrQURBQzNGU3FLTUZt?= =?utf-8?B?L01nUVZpOWF5cEJoa05UZ1VReE5VZWQvenFBSCtpM0swVDBnUUNhSVR0cUho?= =?utf-8?B?YkpWcXhsbkFMcDkrZm1XRTNuallhOW92UFpxeHIzSnB4cVowZXhNMnd4Rzdj?= =?utf-8?B?UitnZVljWUg4a2FwZEZRSjgxM3ZMbThPZSt6UG5QK3N5SGFrWDR6VkhJVDlP?= =?utf-8?B?bjUydjVMNnUzWUJQWURraGdWek9xbkZVMVcvUEtTTUxRdEJlQXRVVk1xMUJn?= =?utf-8?B?VFBqZys0WUVkTS9mbWlBNzZRUzRJdWVYdm1TaHNYTnhTZGx2N3lBRzVQRUdx?= =?utf-8?B?MkRXRUZMNUJPL3B5ZmVYYXZKWFVnUWVPTVBTc0txMVRWSzVSOHJoRU9YSExq?= =?utf-8?B?QmZOZFM3d3FZTTR3Z0M4YkhKaThRbUJaOUZnd2dsVlNNOGZEUFYweGVFcnBF?= =?utf-8?B?RmtJRTk3WXhVejZiZWxocStoZEhaeGczZXN0bU13V3paRFF6bkpmWFRUNHla?= =?utf-8?B?STBUMDdQdnV4d1RTL3ZNTEVVOFVHcVFEVjc1SDVYVkpHVjFTMGZJWlhNV3d3?= =?utf-8?B?YU1vWklDL2NhRDdneVJmRUtNZzAwb1Z6NU9vUnZ5ZXg4YkR1ZGJOakYvZEQ4?= =?utf-8?B?dEh4MFltbHhoUk8yckJnM2ZaL0FDTVpqblRkU0d3eGNLMEtyc3BnaHJjN2V4?= =?utf-8?B?NEsyTDRBNHdOeWZ3clppR25ISDBNT3RaOG5YbnJxMmkvQTR2eTNMVEgvZWRv?= =?utf-8?B?akhGejRWdGVxU2tSeEtLTjljdHJqNDJES3EyQUMyTUJWUVFHWjJBN042YmNz?= =?utf-8?B?NDF0UCtNQ3ZFcisvaDNldW0zU3dDUFJoUGlvdUJ3SXVOUWhrL3hMelpVeTVk?= =?utf-8?B?UWp1c3lUdVRyUGdDWEI5SDRsOXU4QWxIQ0dNSnJsWFduRGhZTzF2YXJxd00y?= =?utf-8?B?alFaVlhWWGwxRkhScWVubXVKTWdDaCt1ckxla2hPMGRlU1VKOHFKRFFueDd1?= =?utf-8?B?WHk4cWhKcjFWdkhsSXpxbjJNcFdjQm13MmZST3Uvek1EU2c4Q0xRR1NqeXR0?= =?utf-8?B?RElRTjhHT2RwNWhqbjE0OWFUS2E0cUVtYlV0Zkc0UXdhOWI2SlJiVW9iRzJz?= =?utf-8?B?akloUTlHYzEyVHpXekhvZms5WWhOSnhhUEQ5ZFM4dFU5WGRwclptZEdacXEv?= =?utf-8?B?T0NweXJoelRaRTBRVGlzdnR1L1hPbXpMenZJbm1VN0NVSG1oZ1d5SklZU21Q?= =?utf-8?B?YmtvdXl1UEx5NVRzOHZ5N0RhYmRDUTlVdFBCTWQ1TlF2eTB4Zjk2dUpmdkY2?= =?utf-8?B?VEVjdG1QUWRtRzNQTDlSMms3U3pldkUrZGRZN0I0bkRTT0xHQXZMeDFUODRH?= =?utf-8?B?R3hmTjJ5TmQxUXpMYlpQWUJWRDNEcUh6WlNyOTJmV010bzh2ODJMWVM4VWl3?= =?utf-8?B?Z3dIWDJOc2ZKb1NEUGpsdFlVNzJzTm80RXY5UzRlLzJBeTFhcjh6aG5XRG55?= =?utf-8?B?aXhlWmRjMGhHRDE2UjVVMFJHeXVmdmdFbXVjUDdvUnA5L05yL2pjZHJ3eCt6?= =?utf-8?B?VUhaV0hMWEs2RVlVMkg0Q0JWTCtBOC9hQzVqQjN1UExqVTFQOEI3NWtKV2RQ?= =?utf-8?B?cm81cTNrNFVLYnp4SHNTeUdjOU15L2FpNEJMdUVaMkRxc3pjRHY0V3FTMzh5?= =?utf-8?B?L2p4R282cHk4M0UrRFVsZmFCT0lJNDd3RVBJYVBMSmEwUHZ0VVRKSjBNNy9W?= =?utf-8?B?TjVXc2tjb1RuUVFnaHl4QkFpZzA3QTNrQ29VZEl3UVBTTFVqdUtjSlFIenpS?= =?utf-8?B?ZWFWbDNuRG9PYU5Zb1FZbFY1Rm0reUpjOEZRL3VQKzJSNTlBd01qRm5WRFhM?= =?utf-8?B?dHRlTVp0cXJQREc5WTN3V2JhL2lVK056K0V3eWw4Skk1cUNRQWhWKzVJU0lS?= =?utf-8?B?cHZaQ1h1aEp3NkV2Sm9NNVZpNk52MzcwcFRFOEVFbFdxVU1yUlJFUjRNMU5Z?= =?utf-8?B?QXRESFBWc3RwejVyWXBYa3JNejQ1ejg5SU10NEhvQ1B0NzB4dkdUS3BaTzZv?= =?utf-8?B?ZGlPTzVucklvY3ZOMDJrWTg3VXFXUTg0OTV3amM0SlNwNWN1Zk1PR0pFR2VH?= =?utf-8?Q?+FTChFepYpXyHooR0k?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7102560-c922-476a-a994-08ded8f215f1 X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2026 10:58:59.7667 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tZUg0ik9K4SEfo5RUYeAZeqWt0nC9k/WZCfnVUwEQen18b2aqR+EKLEYlB8hau0xRpgjqTXgxOsDzZy7jwQnSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8174 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 01/07/2026 17:34, Aktemur, Baris wrote: > AMD General > > On Wednesday, July 1, 2026 6:19 PM, Six, Lancelot wrote: >> Since 246aecb1cd1 "gdb/testsuite: make gdb_breakpoint, runto and >> runto_main use parse_args", gdb_breakpoint arguments changed. The >> gdb.rocm/interrupt-twice.exp testcase was not updated to call >> gdb_breakpoint with correct arguments. This due to the new test being >> reviewed before the gdb_breakpoint landed, but it being pushed after. >> >> This patch fixes this issue. >> >> Change-Id: I0204e2c3cc9b704c79ce01386134e13b018593b8 >> --- >> gdb/testsuite/gdb.rocm/interrupt-twice.exp | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gdb/testsuite/gdb.rocm/interrupt-twice.exp >> b/gdb/testsuite/gdb.rocm/interrupt-twice.exp >> index bdaa3babe16..0e87b5c66e8 100644 >> --- a/gdb/testsuite/gdb.rocm/interrupt-twice.exp >> +++ b/gdb/testsuite/gdb.rocm/interrupt-twice.exp >> @@ -33,7 +33,7 @@ with_rocm_gpu_lock { >> clean_restart $::testfile >> } >> >> - gdb_breakpoint "loop" {allow-pending} {temporary} >> + gdb_breakpoint "loop" -allow-pending -temporary > > Thank you for fixing this. LGTM. > > Reviewed-By: Tankut Baris Aktemur > > -Baris > > Thanks. Pushed as 674d984dd02. Best, Lancelot.