From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OB85ED22vV+OegAAWB0awg (envelope-from ) for ; Tue, 24 Nov 2020 20:41:17 -0500 Received: by simark.ca (Postfix, from userid 112) id 3FEE61F0AB; Tue, 24 Nov 2020 20:41:17 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A7DD71E58E for ; Tue, 24 Nov 2020 20:41:14 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0B1CC386EC6E; Wed, 25 Nov 2020 01:41:14 +0000 (GMT) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by sourceware.org (Postfix) with ESMTPS id 7EC00386EC6E for ; Wed, 25 Nov 2020 01:41:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7EC00386EC6E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wr1-f65.google.com with SMTP id z7so327625wrn.3 for ; Tue, 24 Nov 2020 17:41:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WdwgSixlJoiucxwqdmiTzhSFRQ8Ux7B5placnD2HD8k=; b=Oop0Brwz1A/Q0CxhadFtm76yyBJeZlnZt7FdfBCKZX6dwXnazTGgNPiDc0qkRDUpI3 CkQUe+/J0fbOJ1h+BXfB67m+gKzYCXFOfkiNWcKN8TSBt2xmkIeGr1LzdRy26l996zXN rn1TGug9hSkRv3A26NaI1BPSvQ+9laba0z+JsHArE+giM9UXuaWrLYgmEHG3e8xI0R9H wRMA4ySVlQIOQwaNgMlXSkkzrYSiM22rDKdWlIZnz/YwdTPi9Bw7XsAWe7xmz0lMnWdY QcJrgoTYdnFGxq+N3YrbaVlluvfd/LgT8O4wo4eMm3uRllyAOU5iyrL7GT0oLMbwwHee xZ5g== X-Gm-Message-State: AOAM531Q3yjP+1q6zUhdrjFwUjzE79owoTigcDctFOwkQcFM86OmEVyC 5YMM4TelcoBfK53m1ew5M5CyIOq8dwr4TA== X-Google-Smtp-Source: ABdhPJz9+zecMc5gXlISPNfqC6WNAk0klvK3Inf1mUG4RH2MtsHOmpkOm3xlhS6I9bxfXXNsZj0zIg== X-Received: by 2002:adf:8030:: with SMTP id 45mr1240797wrk.407.1606268469975; Tue, 24 Nov 2020 17:41:09 -0800 (PST) Received: from ?IPv6:2001:8a0:f91f:e900:1d90:d745:3c32:c159? ([2001:8a0:f91f:e900:1d90:d745:3c32:c159]) by smtp.gmail.com with ESMTPSA id a15sm1323310wmj.2.2020.11.24.17.41.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Nov 2020 17:41:09 -0800 (PST) Subject: Re: [PATCH 10/12] gdb: change linux gdbarch data from post to pre-init To: Simon Marchi , gdb-patches@sourceware.org References: <20201110214614.2842615-1-simon.marchi@efficios.com> <20201110214614.2842615-11-simon.marchi@efficios.com> From: Pedro Alves Message-ID: <484ef1ad-3cbf-5462-29e9-aa8b881caa8b@palves.net> Date: Wed, 25 Nov 2020 01:41:08 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20201110214614.2842615-11-simon.marchi@efficios.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 11/10/20 9:46 PM, Simon Marchi via Gdb-patches wrote: > The following patch will need to fill a field in linux_gdbarch_data > while the gdbarch is being built. linux_gdbarch_data is currently > allocated as a post-init gdbarch data, meaning it's not possible to fill > it before the gdbarch is completely initialized. Change it to a > pre-init gdbarch data to allow this. > > The init_linux_gdbarch_data function doesn't use the created gdbarch, > it only allocates the linux_gdbarch_data structure on the gdbarch's > obstack, so the change is trivial. > > gdb/ChangeLog: > > * linux-tdep.c (init_linux_gdbarch_data): Change parameter to > obkstack. "obkstack" -> "obstack". > (_initialize_linux_tdep): Register pre-init gdb data instead of > post-init. OK.