From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26234 invoked by alias); 2 Jun 2008 13:23:09 -0000 Received: (qmail 26225 invoked by uid 22791); 2 Jun 2008 13:23:08 -0000 X-Spam-Check-By: sourceware.org Received: from qnxmail.qnx.com (HELO nimbus.ott.qnx.com) (209.226.137.76) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 02 Jun 2008 13:22:48 +0000 Received: from [10.42.100.129] (min.ott.qnx.com [10.42.100.129]) by nimbus.ott.qnx.com with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2653.13) id L3K4AHNH; Mon, 2 Jun 2008 09:22:45 -0400 Message-ID: <4843F425.90809@qnx.com> Date: Mon, 02 Jun 2008 13:23:00 -0000 From: Aleksandar Ristovski User-Agent: Thunderbird 2.0.0.14 (Windows/20080421) MIME-Version: 1.0 To: Vladimir Prus CC: Nick Roberts , gdb-patches@sources.redhat.com, Eli Zaretskii Subject: Re: [patch/MI] Implementation for break-catch command References: <200805312006.11811.vladimir@codesourcery.com> <18497.57814.496794.333674@kahikatea.snap.net.nz> <200806010914.22980.vladimir@codesourcery.com> In-Reply-To: <200806010914.22980.vladimir@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00005.txt.bz2 Vladimir Prus wrote: > On Sunday 01 June 2008 03:40:06 Nick Roberts wrote: >> >> I think all these "breakpoints" should be changed to use observers. This >> seems to just add to the ugliness. > > They definitely should. Well then, what is the preferred way? I can tweak my patch to take your comments into consideration, but if a switch to observers is going to happen soon, then I guess the break-catch should get this new stuff right away? Implementing observer_notify for all the breakpoints would break the compatibility and require quite a bit of work on the testsuite side. Either way, Vladimir, it's your call - let me know.