From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uuYVK8e8BGW+4BYAWB0awg (envelope-from ) for ; Fri, 15 Sep 2023 16:21:27 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=Yz+FFYyM; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A863A1E0C3; Fri, 15 Sep 2023 16:21:27 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 973771E092 for ; Fri, 15 Sep 2023 16:21:25 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 28FA33858C3A for ; Fri, 15 Sep 2023 20:21:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 28FA33858C3A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1694809285; bh=Rwgoju2dKs1OEm457+GPM/lX9e52RJGKtIgrzmjW7/M=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Yz+FFYyMsyu2eOwCNf3+H84xlKKWav2P/T6bNvpcLd5N2OlL7B+EyceMHmxr2qzpH D/F+OGLbUgBYxJl1AM+sp+WU8nWye4p4sqUUg5IoYNsq/OArDdPTTqL3z2ClF1UiQ0 yNX95Aq4ytga8AuGRpEn/GUIsim26v1pW0swhFGE= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 3B7923858C52 for ; Fri, 15 Sep 2023 20:21:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3B7923858C52 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 38FKJxnQ024253 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Sep 2023 16:20:04 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 38FKJxnQ024253 Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 519711E092; Fri, 15 Sep 2023 16:19:59 -0400 (EDT) Message-ID: <483f369d-b6d4-49d0-a9ed-1434e12fc287@polymtl.ca> Date: Fri, 15 Sep 2023 16:19:58 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] gdb/amdgpu: add precise-memory support Content-Language: fr To: Lancelot SIX , Simon Marchi Cc: gdb-patches@sourceware.org References: <20230915145249.22318-1-simon.marchi@efficios.com> <20230915145249.22318-3-simon.marchi@efficios.com> <20230915160454.qoc3pjpl5fyxgz45@octopus> <20230915171601.cpwzr7yxsfqykdlt@octopus> In-Reply-To: <20230915171601.cpwzr7yxsfqykdlt@octopus> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 15 Sep 2023 20:19:59 +0000 X-Spam-Status: No, score=-3037.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 9/15/23 13:16, Lancelot SIX via Gdb-patches wrote: >>> Moving the initialization in the ctor's body would solve the issue >>> >>> explicit amd_dbgapi_inferior_info (inferior *inf, >>> bool precise_memory_requested = false) >>> : inf {inf} >>> { >>> precise_memory.requested = precise_memory_requested; >>> } >>> >>> The alternative would be to name >>> amd_dbgapi_inferior_info::precise_memory's type and give it a ctor. >> >> In this case I would just do: >> >> diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c >> index 507824decf8d..40baf156d83f 100644 >> --- a/gdb/amd-dbgapi-target.c >> +++ b/gdb/amd-dbgapi-target.c >> @@ -119,8 +119,10 @@ struct amd_dbgapi_inferior_info >> { >> explicit amd_dbgapi_inferior_info (inferior *inf, >> bool precise_memory_requested = false) >> - : inf {inf}, precise_memory {precise_memory_requested} >> - {} >> + : inf (inf) >> + { >> + precise_memory.requested = precise_memory_requested; >> + } > > That would work for me. Thanks, pushed with that fixed (added your Approved-By). Simon