Re: [patch/MI] Implementation for break-catch command

Vladimir Prus
2008-05-28T16:25:52Z

Aleksandar Ristovski wrote:

> Hello,
>
> The attached diff implements -break-catch command for MI protocol (includes the documentation
> changes).
>
> Thanks,
>
> Aleksandar Ristovski
> QNX Software Systems
>
> 2008-05-28 Aleksandar Ristovski <aristovski@qnx.com>
>
> * breakpoint.c (catch_command_1): Remove static declaration.
> (print_mention_exception_catchpoint): Output information only
> when non-MI protocol is active.
> * breakpoint.h (catch_command_1): New declaration.
> * doc/gdb.texinfo (break-catch): Remove @ignore and add text for
> break-catch command.
> * mi/mi-cmd-break.c (mi_cmd_break_catch): New function.

This one accepts and parses a lot of options, and then ignores them. Some
options, like -f, will never make any sense for -break-catch. Can you
please only leave necessary code there?

Also note that the condition is actually meaningful for catchpoints
and catch_exception_command_1/handle_gnu_v3_exceptions actually
tries to set condition. Should setting a condition via MI work too?

> * mi/mi-cmds.c (build_table): Add function for break-catch.

It's not build_table, it's mi_cmds. "diff -p" sometimes lies.

- Volodya