Re: [patch/MI] Implementation for break-catch command

Eli Zaretskii
2008-05-28T19:15:31Z

> From: Aleksandar Ristovski <aristovski@qnx.com>
> Date: Wed, 28 May 2008 13:49:00 -0400
> Cc: Eli Zaretskii <eliz@gnu.org>
>
> Cc-ing Eli for doc. changes review.

Fine with me, except for the following gotchas:

> +@subsubheading Synopsis
> +
> +@smallexample
> + -break-catch [ -t ] [ @var{event} ]
> +@end smallexample
> +
> +@noindent
> +Where @var{event} can be one of:

This "where" should not be capitalized, since it does not begin a new
sentence.

> +@smallexample
> +^done,bkpt=@{number="@var{number}",type="@var{type}",disp="del"|"keep",
> +enabled="y"|"n",addr="@var{hex}",what="exception catch"|"exception throw",
> +times="@var{times}",original-location="@var{funcname}"@}
> +@end smallexample

The lines here are too long: anything longer than 66 characters runs a
risk of overflowing the page margin in the printed manual. So please
break them into shorter lines.

> +where @var{number} is the @value{GDBN} number for this breakpoint,

"breakpoint" or "catchpoint"?

> +the breakpoint has been hit (always 0 for -break-catch but may be
> +greater for -break-info or -break-list which use the same output).

Please give commands you mention here the @code markup.

Thanks.