Re: [patch/MI] Implementation for break-catch command

Vladimir Prus
2008-06-02T14:40:25Z

On Monday 02 June 2008 17:22:45 you wrote:
> Vladimir Prus wrote:
> > On Sunday 01 June 2008 03:40:06 Nick Roberts wrote:
> >>
> >> I think all these "breakpoints" should be changed to use observers. This
> >> seems to just add to the ugliness.
> >
> > They definitely should.
>
> Well then, what is the preferred way? I can tweak my patch to
> take your comments into consideration, but if a switch to observers is
> going to happen soon, then I guess the break-catch should get
> this new stuff right away? Implementing observer_notify for all the breakpoints
> would break the compatibility and require quite a bit of work on the testsuite side.
>
> Either way, Vladimir, it's your call - let me know.

I don't think you should worry about observers -- your patch makes a nice self-contained
improvement, and it does not make sense to mix it with any other cleanups. For now, using
hooks is fine, and my comment about observers does not call for any changes in this
patch.
I don't think any of my comments will be invalidated when we switch to observers.

Thanks,
Volodya