Vladimir Prus wrote:
>> * mi/mi-cmd-break.c (mi_cmd_break_catch): New function.
> 
> This one accepts and parses a lot of options, and then ignores them. Some
> options, like -f, will never make any sense for -break-catch. Can you
> please only leave necessary code there?

Yes, I wasn't sure what to do about them. -f doesn't apply, but -p for example should apply but has not been implemented (yet). I put a warning for now for each valid unimplemented option.

> 
> Also note that the condition is actually meaningful for catchpoints
> and catch_exception_command_1/handle_gnu_v3_exceptions actually
> tries to set condition. Should setting a condition via MI work too?

Definitely.

> 
>> * mi/mi-cmds.c (build_table): Add function for break-catch.
> 
> It's not build_table, it's mi_cmds. "diff -p" sometimes lies.

Yep, and I sometimes just blindly type what diff says. Thanks.


New diff attached. Cc-ing Eli for doc. changes review.


New ChangeLog:

2008-05-28  Aleksandar Ristovski  <aristovski@qnx.com>

	* breakpoint.c (catch_command_1): Remove static declaration.
	(print_mention_exception_catchpoint): Output information only
	when non-MI protocol is active.
	* breakpoint.h (catch_command_1): New declaration.
	* doc/gdb.texinfo (break-catch): Remove @ignore and add text for
	break-catch command.
	* mi/mi-cmd-break.c (mi_cmd_break_catch): New function.
	* mi/mi-cmds.c (mi_cmds): Add function for break-catch.
	* mi/mi-cmds.h (mi_cmd_break_catch): New declaration.