From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ig6EEx2ab2XFbxgAWB0awg (envelope-from ) for ; Tue, 05 Dec 2023 16:46:05 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=DV17h64/; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 401F61E0D2; Tue, 5 Dec 2023 16:46:05 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2796F1E091 for ; Tue, 5 Dec 2023 16:46:03 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BFE9A38582B1 for ; Tue, 5 Dec 2023 21:46:02 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 97A343858D37 for ; Tue, 5 Dec 2023 21:45:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 97A343858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 97A343858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701812750; cv=none; b=S6hAcbkCo6LAw8ZIb9edJbgft8ck2+mHdEKna07cx8nUL+0yeYstjY0dUpzmig/qHdmtaLgXhEKLVtyuOK5ONKrjdqVFJ4FWYHSxgv0bQxNJkSNARXyZK5ninLNiTxUjEXBiURIaaK8ucvm4pkE151zXSFSlSE8Nenip62Xg9Yw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701812750; c=relaxed/simple; bh=wWQwBOkGNXf3toXNqt5L7FACm5wXFNBLeAlvMpVk7fk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=u8MLN+AgZVUtMcXf6ND1IjTD7HzTm8NYOLTvnA1hSSLefT0ZuCeiTl9eAe9GbiHourdXD1UhzReyG0Lo+o+RT/9boteaJX+2f49ftvtlK3e6rsNxEtYesgmx53kobD/gCKdpLoyBCM0f0wcbQYX2Ew1M6AYjAahyB1I6LEmJgpE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701812749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=stxx2IVuGrJUUHQkwBFHugNbjyNNTbncqFHx0SUtS5c=; b=DV17h64/PixrBBhD5csXn1YiPQ4yZJNmtyy02SZ44i0Q7rLVLUSLKMMZ0+nkNeksYjhhSu hOJN1kXDtWT1WgfpbNS2SLKP8KVe0Gc9O+AulhW5Q9WIb3iMR3u46wL+RRLVO9Bb3ajUWA T4hEKTitZ5/YnX7oFSoHXmVUzY1NQJA= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-20-ecztu5ixOxKGQDY9HmlRKg-1; Tue, 05 Dec 2023 16:45:48 -0500 X-MC-Unique: ecztu5ixOxKGQDY9HmlRKg-1 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-286a4fc4e9cso3290018a91.0 for ; Tue, 05 Dec 2023 13:45:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701812747; x=1702417547; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=stxx2IVuGrJUUHQkwBFHugNbjyNNTbncqFHx0SUtS5c=; b=YRQXHeWMeZOKt/89fHppzakUjqCukvKxipPpUxyYyiesLNV17GwQztqWRObvRVHE2Q qe3OJ5u5DtAJg5wlXvAgx5s83v0GNBDEABxrqD32Oco246RsSxQpvHpOmXWZ6sRRfMJL dRKHz5uVQryWAO+aXgGphYUT+CCpBOLU6p5AlpsT4ndz3z/XTx64H+10nekk95fPnjb/ s49bCITA/FxKIynITUhZ+luYfYmJr5m4SYUPTh02+kz0oEP88hbBH+5GAfAqQeQYFuAs 7IzW8gTVkOBuhq2FgK/OdqFCw9XozWnD5N1awnp5/cFFihIT07r2LrPOmyoc+naWJ0di ZicQ== X-Gm-Message-State: AOJu0YxmmnUyzaM5wI6c1Z9p7Ki//B8ecfn3yA8lyppQmtNIljZML665 i+hhX/B0KohLKw28o0KNZ25JsC7V1FfvESXJ9QMpz84KwrYeQOrRVdtwvGr85kA1QWUnx4W0+pP jBDWm+EvdcpMSF92qlgxZ0A== X-Received: by 2002:a17:90b:143:b0:286:77c2:6027 with SMTP id em3-20020a17090b014300b0028677c26027mr1971567pjb.36.1701812746913; Tue, 05 Dec 2023 13:45:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IFvFHgkQVRMrtLXfo2Re/M/ih2Tal7WMOwSEuwY7ph7E6I6SAgC0xLLuVgZFQXdluB2jdqjMg== X-Received: by 2002:a17:90b:143:b0:286:77c2:6027 with SMTP id em3-20020a17090b014300b0028677c26027mr1971559pjb.36.1701812746581; Tue, 05 Dec 2023 13:45:46 -0800 (PST) Received: from [150.1.200.12] (174-21-85-118.tukw.qwest.net. [174.21.85.118]) by smtp.gmail.com with ESMTPSA id u3-20020a170902714300b001d071ed0bf1sm1688903plm.272.2023.12.05.13.45.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Dec 2023 13:45:46 -0800 (PST) Message-ID: <481d8b16-8e3f-45aa-9c01-ed398bb63dd5@redhat.com> Date: Tue, 5 Dec 2023 13:45:45 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: make gdb_get_worker_threads reads default number of threads To: Guinevere Larsen , gdb-patches@sourceware.org References: <20231205152609.741237-1-blarsen@redhat.com> From: Keith Seitz In-Reply-To: <20231205152609.741237-1-blarsen@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Hi, On 12/5/23 07:26, Guinevere Larsen wrote: > One such example is the current buildbot instance (at least the clang > version). This commit adds a new clause to the gdb_get_worker_threads > that detects the default worker thread message. > --- > gdb/testsuite/lib/gdb.exp | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index d0990dcfe0e..148476cf42d 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -10034,6 +10034,9 @@ proc gdb_get_worker_threads { {testname ""} } { > -wrap -re "^The number of worker threads GDB can use is unlimited \\(currently ($::decimal)\\)\\." { > set worker_threads $expect_out(1,string) > } > + -wrap -re "^The number of worker threads GDB can use is the default \\(currently ($::decimal)\\)\\." { > + set worker_threads $expect_out(1,string) > + } > -wrap -re "^The number of worker threads GDB can use is ($::decimal)\\." { > set worker_threads $expect_out(1,string) > } This is new: 33ae45434d0ab1f7de365b9140ad4e4ffc34b8a2 Date: Mon Dec 4 14:23:17 2023 +0000 gdb: Enable early init of thread pool size That commit changes the "is unlimited" text from maintenance_show_worker_threads to "is the default": gdb_printf (file, _("The number of worker threads GDB " - "can use is unlimited (currently %zu).\n"), + "can use is the default (currently %zu).\n"), gdb::thread_pool::g_thread_pool->thread_count ()); So this patch can be further simplified. Otherwise LGTM. Reviewed-by: Keith Seitz Keith