From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19258 invoked by alias); 15 Apr 2008 14:44:21 -0000 Received: (qmail 19247 invoked by uid 22791); 15 Apr 2008 14:44:20 -0000 X-Spam-Check-By: sourceware.org Received: from qnxmail.qnx.com (HELO nimbus.ott.qnx.com) (209.226.137.76) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 15 Apr 2008 14:43:57 +0000 Received: by nimbus.ott.qnx.com with Internet Mail Service (5.5.2653.19) id <2FVR0570>; Tue, 15 Apr 2008 10:43:54 -0400 Message-ID: <4804BF23.10505@qnx.com> From: Aleksandar Ristovski To: Daniel Jacobowitz Cc: Vladimir Prus , gdb-patches@sources.redhat.com, nickrob@snap.net.nz Subject: Re: [patch] fix for PR2424 Date: Tue, 15 Apr 2008 15:07:00 -0000 MIME-Version: 1.0 X-Mailer: Internet Mail Service (5.5.2653.19) user-agent: Content-Type: text/plain; charset="iso-8859-1" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00289.txt.bz2 Daniel Jacobowitz wrote: > On Mon, Apr 14, 2008 at 10:41:38AM -0400, Aleksandar Ristovski wrote: >> ping? > > Thanks. The most recent version of this patch (code + testsuite) is OK. > > Please mention the PR at the top of the changelog entry, like this: > > DATE NAME > > PR gdb/2424 > * infrun.c (some change): .... > > Then if you include that line in the commit message, the changelog > entry is automatically appended to the PR audit trail. > > Shouldn't the disp="del" field be described in the manual? If so, > that can be a separate patch. > Committed. NOTE1 (reminder): With this patch, we have new field in the *stopped message, when "reason == breakpoint-hit" - we will have "disp" field printed; the value of the field will be exactly the same as the value printed when the breakpoint was created. NOTE2: Due to quite significant rework of certain functions in mi-support.exp, committed diff for testsuite is not exactly the same as the one I posted. I took liberty to commit anyway since the changes are functionally the same; note the slightly awkward syntax for "mi_expect_stop" call, namely the "extra" argument which now must be something like { "" "disp=\"keep\"" } - I don't think it's too bad (it can be beautified later). NOTE3: In mi-support.exp (mi_expect_stop), I put argument "after_reason" to be after the reason (I couldn't find it being used anywhere anyway, so this should be a safe change). NOTE4: Documentation is not updated (I will try to do that now and submit the diff for approval). Thanks, Aleksandar Ristovski QNX Software Systems