From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by sourceware.org (Postfix) with ESMTPS id 4584C388702E for ; Wed, 8 Apr 2020 17:21:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4584C388702E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1586366514; bh=RJhHqX0d7OrJQrk5C5u9PMEmgt9iPsy0WSSp4GVGPBY=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=aQ/KwlFEaquuOCIfaW+lR9r9EXIjip2Blfu0ok+L5IAm7soFaow0LEWt8se7QQMlt ky4GHx6cPsM4p8/7FsjNAXP7AR8HsafmVO9GM/CUU4itqJKopkC1k+FTLnydQDn559 76tl3g/T/jy+Lujn37LvXTg21B3nhcxb+J0TQwz4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MBUqL-1jRUNy37Tb-00D03C; Wed, 08 Apr 2020 19:21:53 +0200 Subject: Re: [PATCH] Tune default DEBUGDIR for NetBSD To: Christian Biesinger Cc: gdb-patches References: <20200408171543.6061-1-n54@gmx.com> From: Kamil Rytarowski Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Message-ID: <47fe1112-261b-6d31-3ec4-1cb3ed27ea64@gmx.com> Date: Wed, 8 Apr 2020 19:20:42 +0200 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:KiYTDzfKKSErIqHn1mGj7g5y7g5RCIYdc8blxQzOC7szThBSSr5 WP8VDDiJbznPcWUVsKwwR1+MY6Mff0XpH/ORECSpWvmC01dDpVfw91SsirUqZ0gbsnzauz+ DmEDC6CxiHE5Y8NmPJmLfxhpmPMPuucwY2nsBlRCfhKPc+evYHY3kq7YiwWM8x5DoSnswEB 3kAXejxUSdq+sdi9XSybw== X-UI-Out-Filterresults: notjunk:1;V03:K0:8b+JFE8R608=:6EeP+rQ9ZVQ3U2DOr31W8j Tfsvl3LkN3tVPG2UIUEuzr//FTdAWbQKhJPggN8/UWF5VjQZypN9P9Q/KGC79eVuavmT5U17K P6CVyj3a7brNCeZLqwqK3g9y1pPaNoBLP4rUiwbUZQsrpLk8tkLXRl1XwNe6o8ISAKnGpHQED zAP9m2/d0Fqa+fvXU0pBT0Ebgm7yuk1yxMepxkgPBe8agqeyY2P+CySNSge5MFo8A4Kz22+B5 e7YtCTZcSxXODhZKitTqgcEKJA4P1h9ugLpIkL5YdA1lTMi5xPe4Mxn0dJZ3bRsqwkK32BRNG a0IJZBUhHEAbJTWuM4Pxhf6pWVb8dWKw2eha+MwuSTk2Uz9I7kk4/O1/Z2OO7sI4/ico0Ii6N hobW6WweTolabEeXkvmBas2hJxb2WDXsnRo2Mplx0L0uU44LTSMEcAGzIs1aasHeLo9l9Ctdn iWfr7tcrHAlHmrXYWFGVTB+na5+ZaGrhp7mwU1n2lpMHXtI3zWRszPY3/M51drNSRk4UJ1NJK 96YBeo4exfnZ+Il4ROXAZnotFqYtnvidhhgDV6I8xPDnsPTS636gZNdeWtCHufkNYZHVtA6y1 KfTu2aVDoK2e2AbPTQLYCT0e+Wj55waTN5GKQ/gwRp+9fzEC2gIxxs3DKEySL82v9REPEogG7 +APq2Y/+t1WeNsQzCuJneBObyE1A+ytjl2CpWr8RhxRUzVvLG3ZzirvtDu78ah6F3RkLpy+9g Prbozw1vxLmVOj6VLai5XlCXIPBpr5Id0S4ZlYe0fRIhfqW0+rWs529bb3pp2C4iT+iGQ/PkK y0M9e+g0EllZoz2rVYl2OPtIe6jkkxWufgWkjJmucXo6tQNEm2Gpzj9NzSKrBNF8oq/hOOgsy JXvjLlFeDWKjk7Rwzsr0h9SuVKtm3JLVcp3OIdTZffCbju1xfg1T4SwN582qF3pleV7ekv240 tT5TJ/fWbZwW9hzuIZN3qSC5FJ29sYLWDTaQNTekJLXmJTje9Ua8PLT1QcduXEey0+gPVtKHZ mDfsoXO+0a8/rtaUT1yMh+1RKjhTC7m0K+fbqHVJK1N+nlnWwiNpkxNSiobfpNYlfeDJsJrvz jirSSDb3ATax1Su7JXkKlEChh8q35cKMEP0lWjVo7VwjjdjmefEl0m1YPhKVFC9MvO9+3aQlE gds27+2pYpf1EPphHOSXfczgkOm0EnJCq+xNpVYFtimVnbNlEkqu0bRwuA3xQj0/U9stA= X-Spam-Status: No, score=-28.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Apr 2020 17:21:58 -0000 On 08.04.2020 19:18, Christian Biesinger wrote: > On Wed, Apr 8, 2020 at 12:16 PM Kamil Rytarowski wrote: >> >> NetBSD uses a custom debug file directory /usr/libdata/debug >> for the basesystem and does not use separate debug files in >> pkgsrc (3rd party package collections). >> >> gdb/ChangeLog: >> >> * configure.ac: Handle NetBSD specific DEBUGDIR. >> * configure: Regenerate. >> --- >> gdb/ChangeLog | 5 +++++ >> gdb/configure | 11 ++++++++++- >> gdb/configure.ac | 11 ++++++++++- >> 3 files changed, 25 insertions(+), 2 deletions(-) >> >> diff --git a/gdb/ChangeLog b/gdb/ChangeLog >> index 7ea85799211..af6844b6ace 100644 >> --- a/gdb/ChangeLog >> +++ b/gdb/ChangeLog >> @@ -1,3 +1,8 @@ >> +2020-04-08 Kamil Rytarowski >> + >> + * configure.ac: Handle NetBSD specific DEBUGDIR. >> + * configure: Regenerate. >> + >> 2020-04-08 Simon Marchi >> >> * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile >> diff --git a/gdb/configure b/gdb/configure >> index afafc2c8d18..636a3f69f00 100755 >> --- a/gdb/configure >> +++ b/gdb/configure >> @@ -6416,6 +6416,15 @@ if test x"$gdb_cv_have_makeinfo_click" =3D xyes;= then >> fi >> >> >> +case "${host}" in >> + *-*-netbsd*) >> + DEFAULTDEBUGDIR=3D/usr/libdata/debug > > Wouldn't it be better to make this ${prefix}/libdata/debug? > Not really, as this path specifies the userland debug files only. In third party we don't use separate debug files. The default prefix is /usr/local and without specifying --prefix=3D/usr debug files won't work. This path is already hardcoded in LLDB for this OS. >> + ;; >> + *) >> + DEFAULTDEBUGDIR=3D${libdir}/debug >> + ;; >> +esac >> + >> >> >> # Check whether --with-separate-debug-dir was given. >> @@ -6423,7 +6432,7 @@ if test "${with_separate_debug_dir+set}" =3D set;= then : >> withval=3D$with_separate_debug_dir; >> DEBUGDIR=3D$withval >> else >> - DEBUGDIR=3D${libdir}/debug >> + DEBUGDIR=3D${DEFAULTDEBUGDIR} >> fi >> >> >> diff --git a/gdb/configure.ac b/gdb/configure.ac >> index b9dbe13232a..3cef95fbcb8 100644 >> --- a/gdb/configure.ac >> +++ b/gdb/configure.ac >> @@ -93,9 +93,18 @@ if test x"$gdb_cv_have_makeinfo_click" =3D xyes; the= n >> fi >> AC_SUBST(MAKEINFO_EXTRA_FLAGS) >> >> +case "${host}" in >> + *-*-netbsd*) >> + DEFAULTDEBUGDIR=3D/usr/libdata/debug >> + ;; >> + *) >> + DEFAULTDEBUGDIR=3D${libdir}/debug >> + ;; >> +esac >> + >> GDB_AC_WITH_DIR(DEBUGDIR, separate-debug-dir, >> [look for global separate debug info in this path @<:@LIBDIR/debug= @:>@], >> - [${libdir}/debug]) >> + [${DEFAULTDEBUGDIR}]) >> >> # We can't pass paths as command line arguments. >> # Mingw32 tries to be clever and will convert the paths for us. >> -- >> 2.25.0 >>