Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Subject: [committed][gdb] Fix warning in print_one_insn::ez80-adl
Date: Sat, 4 Jun 2022 11:12:03 +0200	[thread overview]
Message-ID: <47f7edc3-e0ae-e816-ffe9-5eed7c74d773@suse.de> (raw)
In-Reply-To: <20220602154425.GA7631@delia.home>

On 6/2/22 17:44, Tom de Vries wrote:
> Hi,
> 
> When running selftest print_one_insn::ez80-adl we run into this warning:
> ...
> Running selftest print_one_insn::ez80-adl.
> warning: Unable to determine inferior's software breakpoint type: couldn't
>    find `_break_handler' function in inferior. Will be used default software \
>    breakpoint instruction RST 0x08.
> ...
> 
> Fix this by explicitly handling bfd_arch_z80 in print_one_insn_test.
> 
> Tested on x86_64-linux.
> 
> Any comments?
> 

Committed.

Thanks,
- Tom

> [gdb] Fix warning in print_one_insn::ez80-adl
> 
> ---
>   gdb/disasm-selftests.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/gdb/disasm-selftests.c b/gdb/disasm-selftests.c
> index ccb60a0bc87..ff3c53c6104 100644
> --- a/gdb/disasm-selftests.c
> +++ b/gdb/disasm-selftests.c
> @@ -86,6 +86,13 @@ print_one_insn_test (struct gdbarch *gdbarch)
>         if (gdbarch_bfd_arch_info (gdbarch)->mach == bfd_mach_arc_arc601)
>   	return;
>         goto generic_case;
> +    case bfd_arch_z80:
> +      {
> +	int bplen;
> +	insn = gdbarch_sw_breakpoint_from_kind (gdbarch, 0x0008, &bplen);
> +	len = bplen;
> +      }
> +      break;
>       case bfd_arch_i386:
>         {
>   	const struct bfd_arch_info *info = gdbarch_bfd_arch_info (gdbarch);

      reply	other threads:[~2022-06-04  9:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-02 15:44 [PATCH][gdb] " Tom de Vries via Gdb-patches
2022-06-04  9:12 ` Tom de Vries via Gdb-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47f7edc3-e0ae-e816-ffe9-5eed7c74d773@suse.de \
    --to=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox