From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106544 invoked by alias); 16 Nov 2016 17:12:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106528 invoked by uid 89); 16 Nov 2016 17:12:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Nov 2016 17:12:45 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D6448C05005E; Wed, 16 Nov 2016 17:12:43 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAGHCfwI010337; Wed, 16 Nov 2016 12:12:42 -0500 Subject: Re: [PATCH 2/4] Remove code that checks for GNU/non-GNU make To: Andreas Schwab , Eli Zaretskii References: <20161116160808.12830-1-simon.marchi@ericsson.com> <20161116160808.12830-3-simon.marchi@ericsson.com> <83mvgzfkrr.fsf@gnu.org> Cc: Simon Marchi , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <47f7d5aa-508b-d132-4899-a4cef265b06a@redhat.com> Date: Wed, 16 Nov 2016 17:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00432.txt.bz2 On 11/16/2016 04:39 PM, Andreas Schwab wrote: > On Nov 16 2016, Eli Zaretskii wrote: > >> Since GDB is built by first running Make in sibling directories, which >> don't require a GNU Make yet, what does this mean in case the user >> runs a non-GNU Make? Will they have strange errors half way through >> the build? Should we detect this early on and bail out? > > The toplevel makefile already has such a check, only enabled for gcc for > now. Might be worth it to ask the binutils@ folks if they're OK with requiring GNU make, and just making that unconditional. Thanks, Pedro Alves