From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id RRSSNeIb72WYjAIAWB0awg (envelope-from ) for ; Mon, 11 Mar 2024 10:57:38 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-armh-onmicrosoft-com header.b=2Czy0trU; dkim=pass (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-armh-onmicrosoft-com header.b=2Czy0trU; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C95241E0D2; Mon, 11 Mar 2024 10:57:38 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A2CFD1E0AC for ; Mon, 11 Mar 2024 10:57:36 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1F64F385842D for ; Mon, 11 Mar 2024 14:57:36 +0000 (GMT) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2050.outbound.protection.outlook.com [40.107.22.50]) by sourceware.org (Postfix) with ESMTPS id BBFBD3858D20 for ; Mon, 11 Mar 2024 14:57:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BBFBD3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BBFBD3858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.22.50 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1710169035; cv=pass; b=mnYE3PD7MehvZj2OfmxI9lxCGrhheSRgBwKcrrrgzR/2jn+nZ5jMKwxz3IW1xZ6Uqm8qajgwaHp0p7/0KaaEVOoFr0NVaf4hGHPZam/Uzf9/3V58mOGtEW0kdbOq31tsFhIJ/cwF6bisUjocO1ao6aSyUsNqL1269mvzynrSqiw= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1710169035; c=relaxed/simple; bh=Yg/dkEZ2ln3wN6EIeUC5ud6huZBGxTqWoyW+UhpCMHs=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=qyN/TyNrHm32eJV2ybu7aMUdLaDFBVm9dbbmztETu2Zj3Jx8bDtpZ5Rbok5WdQCjKPUjuV3oLQahxZsSmPLOgvVY5Fco8PgXzFHslvwsTlGpN6CjOepRdCDVJawYh7y98f2m+ykS8jew8KZu0gCqMOoVSn+fcu1kJgXHpgcpeME= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=O6ML9lxEG4sBglk9cx6tggcDVQcGMNw2P+xkRvGZzZyP2tI3ISqbEYNLdC4xz41PdYEcenyLlIMDKZCGvnrSxP93ZzzCLVzAYu8Jf01w4BnEYlLnuyTdxxNSZC9Nvo3K7bsBy7ezveENuTjTv+ZxiKm6Q6ALLjNzPBRKyKVMjJrgA+CkR+xeF27+10is9ODLUg0jaHd/Dt/Gkxji2PRrUB56MjW1Yai/d2AKA70zqALrLlXYhMDk5Lr7C73PVe+32LV1SdGDW0YP1fkTrNUXPoN0fBknmURENKgBAPlLXMKpn+AgsdUE1m6ioCCGEBh1BeZI7+Wt1hzPmFqSemXVww== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FnHYDyUKifMRYFswURcWNavv+6NwlRaSTsMPcnUqe1s=; b=QzZ9exbpJ8xh5UMKn/jlxB95hNPZ+9bduuII8mFycORNyAo3bVAxrfGkfSnh4vUFJ/yo1MaKGfpdO2rKqdki8HlPE6mZS0phf2aRirf/LNlE7pn3+tleJIP+cW0LfzkB9/U6GwbiZ8H1eD6mkANHuljDKG5XmuQ8YCOdshc9jFv5gmBMI0gRtSUNc9DdCci3+DjblXvPAfIld2CWb8Yerp68MsYBp2vrIz8FkMN/cQYfbpNmi41chKY6nRO7s3egs7TnetCNl9/2LuSgrlsnhoIx27SALB5XxSaXVlsGiBvFVW0R58H0es+xOJxCuprPj8QiOUPibWliq5wTwfqxyQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FnHYDyUKifMRYFswURcWNavv+6NwlRaSTsMPcnUqe1s=; b=2Czy0trUcH8u+JuKzxM8uSQFe5I0JftN5yp+Ip2ON3UsXaJih3Bpr8+peIR7qDoROIbF6rVsHJmr5o/JmBGkkXOTTVQ7V6cDypsZJ/FIxl/ccaJq/+DxCLVqete6ehMCzHvzLHbbil+xbtMTQFcmlQK41pQag/63HjM9h68yM0Y= Received: from DUZPR01CA0273.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b9::14) by PAXPR08MB7491.eurprd08.prod.outlook.com (2603:10a6:102:2b6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.35; Mon, 11 Mar 2024 14:57:11 +0000 Received: from DB1PEPF00039230.eurprd03.prod.outlook.com (2603:10a6:10:4b9:cafe::5e) by DUZPR01CA0273.outlook.office365.com (2603:10a6:10:4b9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.35 via Frontend Transport; Mon, 11 Mar 2024 14:57:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB1PEPF00039230.mail.protection.outlook.com (10.167.8.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.12 via Frontend Transport; Mon, 11 Mar 2024 14:57:10 +0000 Received: ("Tessian outbound 7b0d57313a48:v276"); Mon, 11 Mar 2024 14:57:10 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: db1c0114b2f88a7a X-CR-MTA-TID: 64aa7808 Received: from 02096c1c55ac.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 36CAEFF0-535C-4D61-8F8D-1B8FF3F30C94.1; Mon, 11 Mar 2024 14:57:04 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 02096c1c55ac.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 11 Mar 2024 14:57:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jmg3vBz8N2hD9+/8fN9ivijF2AJRqpJY42fO0kNZGk/sSanS++TKpExvT8k9XeeblL3njfBl+7/mIUsbnwACkrvc7Iysacql3NCvlWcxZjehtyh9aGhyu9HWrXWt3OLW1kxs3djdPk+sqiUEJWoNVV65emXztY5huWH2qqrDBHYZPvEddvRH6w+EVD2aCAb7qErfhMs8rVrl5GgGD/QR2sZXXVy6JCJ+JkldSbprurAdgceapoyh2yvZCyLOrqkpNAr0EXxZf8VArlqNZL9qt51SvmXMEKlhzfGwcrJA77AQwzQovcGO6WFWmIouvLU9u8GW76LWQyn6krM5tyI/GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FnHYDyUKifMRYFswURcWNavv+6NwlRaSTsMPcnUqe1s=; b=aYSPC9ZaO8ON6d25jJe4tiWB8My762TR7/AadFjDAq2KXJQ3X9ZiNFn5VlC/yH5Cmo2VqFPbUiaMELTzj9NGa39IXmbDR6+gWlssmZxrTXs4Ad8NtNcArkeVog/IKO1JMGt8apEjQ74QLhe6e9DV7J3epiegTCH9E9JTMKacOlozXgA77KHV4DXYROFj7C7HItieQFgg7j0Mk8ex+yBwsqMXNEjo/jNAG8EFgxvYFYqWvJXBeyVOs9Z/jh4zlCprEVF29FdOWpBwroZUnd0i5YrkvB4djCg1rz3DARMFcVcnfBDbcsy2URFJylobo6crqn6p8tG/gFDZFq12itH7lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FnHYDyUKifMRYFswURcWNavv+6NwlRaSTsMPcnUqe1s=; b=2Czy0trUcH8u+JuKzxM8uSQFe5I0JftN5yp+Ip2ON3UsXaJih3Bpr8+peIR7qDoROIbF6rVsHJmr5o/JmBGkkXOTTVQ7V6cDypsZJ/FIxl/ccaJq/+DxCLVqete6ehMCzHvzLHbbil+xbtMTQFcmlQK41pQag/63HjM9h68yM0Y= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by PA4PR08MB5997.eurprd08.prod.outlook.com (2603:10a6:102:f0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.33; Mon, 11 Mar 2024 14:57:01 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::363f:3fc8:fc36:58ed]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::363f:3fc8:fc36:58ed%5]) with mapi id 15.20.7362.031; Mon, 11 Mar 2024 14:57:01 +0000 Message-ID: <47e1bce0-1f4f-4ac4-b101-a2496a51cbe8@arm.com> Date: Mon, 11 Mar 2024 14:56:59 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] Modernize frame unwinders and add disable feature Content-Language: en-US To: Guinevere Larsen , gdb-patches@sourceware.org References: <20240306125135.766567-1-blarsen@redhat.com> From: Luis Machado In-Reply-To: <20240306125135.766567-1-blarsen@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0195.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::15) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|PA4PR08MB5997:EE_|DB1PEPF00039230:EE_|PAXPR08MB7491:EE_ X-MS-Office365-Filtering-Correlation-Id: 79022cef-237b-4d0d-6888-08dc41db878f x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: OdegdqdRtkszpOQI3SSBKdeGVsjyhHvgLAECs5ByK0uGjXVNfS1tCkBg9R97KUSJZ5HhTKDQbCvbQi7bU9P50TpvV4M+ZOKQ8iP9+J1YjTMXOWPoOvpy4wCiDFtER6+/kh5r/bYExrMQ0wZJoMXfxvask4ZGyeKMeZJXZ+KQnaHJWZ5UrGhu16aotEgg4awpTV89KWODQhsm5WYKVqwRoJiePTn26/OQfbsR7RuGPUGWDipQAny/Hb19wKJMEQgR0g5aqnU2YE0FAEAjqWB0GKGNbf1wgPNvzq0jCDKZmWQltSuZtUH4LIGBzKs2ZHjnqs1W72NHK19++8M864SIhrCGICimhFMsuZIlNFOtuH0xAmbzcoIPczXdJyOeaXy+YAY7wz8JOhGYaISeY2M+3E0yWcZ1hjeIhSx6AGfjrMuqae2w0NgCvHWgG4v6ApJ2lHemYAqsC3LA64+OfUmBp+Vl9HcPaa5VYMQgSQqaXEK/8OrlR2xgkmRFHL2CPg6hqda0sFaypyS8d1Ao/a5EXYJccjtEJpQEco4UnkviPmUWV1Khz36wpeeVsw/rU5KtcJID7YHq8uw3ozB11MeBeZ0qsaL/Acmd33SIMmMpXo8KfgXdpaFQyKBsH6CoG/G35Oc4suiFOfMAx1VteSVR5k9r87hSTdEAX4rVV8+1dXc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5997 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB1PEPF00039230.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 35ecbf94-034d-45cf-c5be-08dc41db81fc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MN+ZBnv7I6e6Oe9V7ESP4Vh9I+bp1//WJgA0xc9oDyUaa4lIkNOjFIArFOkPs1CVAFNeslJrYpYspbtvGjMY/Ba7MpB3T+cWCoOfh4siVT/9nqV1FgM53d/ZlN1n5CNRyHo0f7DqNdNzLQGZRqjSs1GlNpKO2P/v6l+jkPFqDKVBb/cTaNgg0hfbTIaSfm2hdbuDUCTOIdxBtvyyMkEz45X4+9RJs5dN6OKpmaluK5fSL5ZXPxyndV/1ZCSMXI5Cv+quF6ivytfH9kxrek/4z+V/8R0cOmcezY+5wMbVhoukSo+AVj+DI5KBUwLmMU+tPgAfUKYax/3+hcEtUim74Aj/v7R0b5DvpfKr/xUv3dMP//VldP/7v1GmqfNzdwU4NUrUvDIyMV5b37rWHmmA7KAch4hM0ptFzDfEa7Q7+Z1j+T+77ZohO0IG2py6vYI/apJX7ggtqiatiSc0fCtyCP7+zFfo9gIYtkQ6r4+zJwmoQNUJzDVO4rGTqTT+Qxhtp1hkp5d1+DDSTfcp6i0HbYP4tnCDhh9h2+GxflAcnjYsuKaaMhxbnQGdcibccEZvkumPmufhQAW/QLNqlJc3rgNBG3EKCh+nKkuzpq5v3SmAp2CA+CN2c1WwVLuKlPRr7hxkpjwmUoWpd3K69B1HP6O5MIjP+Oo3L3Sg4M7SpLeCPSixUQuedTTwYFuGtwhPod0RYFqvVGqTMyGV1LtyogqewrB9g08HB7l5+4my8lXec+0zG/o1JEoDnobCfbNa X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230031)(36860700004)(1800799015)(376005)(82310400014); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 14:57:10.7733 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 79022cef-237b-4d0d-6888-08dc41db878f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF00039230.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7491 X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, KAM_DMARC_NONE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY, WEIRD_PORT autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Hi, On 3/6/24 12:51, Guinevere Larsen wrote: > This patch series started with me trying to make it easier to test GDB's > ability to unwind using CFI data, to improve a previous patch I sent to > the list. However, once I finished these changes, I realized there was > an unrelated bug I should fix before proposing the CFI test. Since these > changes are significant enough already, and I think would be interesting > on their own, I figured I shoudl submit this patch series as is right > now while I figure out the other bug. > > The first patch is just a minor change, storing frame unwinders in a > vector instead of through an unwinder table accessible using the > registry system. This isn't required (like I originally thought it was), > but it does make the whole system more readable in my opinion. > > Patch 3 has the real meat of the modernization, making GDB use > polymorphism to handle frame unwinders. This is slightly slower than > using function pointers, but much more readable in my opinion. > > As for the unwinder classes, they were chosen somewhat arbitrarily, > mostly based on where I found an unwinder and its name. I almost expect > some unwinders to be mis-categorized, but that should be easy to fix. > > The changes up to patch 3 have been tested with a try-branch, no > regressions as far as I could see. > > Guinevere Larsen (4): > gdb: make gdbarch store a vector of frame unwinders > gdb: add "unwinder class" to frame unwinders > gdb: Migrate frame unwinders to use C++ classes > GDB: introduce ability to disable frame unwinders I haven't gone through the series in detail, but I thought I'd give it a try on one of the aarch64 machines I have access to. I didn't look particularly healthy: # of unexpected core files 47 # of expected passes 116521 # of unexpected failures 581 # of expected failures 77 # of known failures 116 # of untested testcases 128 # of unresolved testcases 1102 # of unsupported tests 458 # of duplicate test names 10 I see a number of internal errors going on. Mostly like these: ../../../repos/binutils-gdb/gdbsupport/errors.cc:58 0xaaaad27e7877 check_ptrace_stopped_lwp_gone ../../../repos/binutils-gdb/gdb/linux-nat.c:1634 0xaaaad27e7877 check_ptrace_stopped_lwp_gone ../../../repos/binutils-gdb/gdb/linux-nat.c:1630 0xaaaad2ae0fa3 linux_resume_one_lwp