From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id LJW+JPlkwGffoz8AWB0awg (envelope-from ) for ; Thu, 27 Feb 2025 08:13:29 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=q/yLe0/s; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=txFsR+/b; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=q/yLe0/s; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=txFsR+/b; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 87CAE1E105; Thu, 27 Feb 2025 08:13:29 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 074B01E08E for ; Thu, 27 Feb 2025 08:13:28 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9A7853858C50 for ; Thu, 27 Feb 2025 13:13:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9A7853858C50 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=q/yLe0/s; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=txFsR+/b; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=q/yLe0/s; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=txFsR+/b Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id B2D743858D26 for ; Thu, 27 Feb 2025 13:12:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B2D743858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B2D743858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1740661976; cv=none; b=QD24rTXVJNXgu6yj9pgp00W76NLpfIQcCLzcPO/im/cTNZ56JXu4a6Usp4X+rJQMvhMe/Kiy+gRC9iV3C0a116hOZGYNKlbq3yXo17ZzOraG4WI2sg6eh7XjCHClgYqGz09/f/K/Ti3uRON78/PqeX48zx3sgLBploTvmFC2t9U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1740661976; c=relaxed/simple; bh=zUjISaNuopHUSOQetHCxdhYd2Q1oKjhGZ3DJxcZLVNg=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=vyja863Qs7kjcXZ5wUH0Y+X1M65D8y1u1XSTOswfCTaO9QpquDLAorNES0oaGd0cftWvs0NRtsdmRLx9lG8LYrE1T+9BWSLPSrfXKRwRyGg73hd3SHVixpy8hgUa5ThkrwFrerXZyZN5Oqg6CKGlcWsbyQhlZCh7ctLdkoWC3WY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B2D743858D26 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 68E871F38F; Thu, 27 Feb 2025 13:12:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1740661975; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0Jmr+rx5SptwuFQQlY/5oQ70jGVx0YKjoc9pywPeMs0=; b=q/yLe0/saIQabE3ziB3fJwCC26HCLdW09bjj2O7Tv+wSH2UfvfcObzKZmk2I8fm/Jx59zO ALzd+C0FreMuSdA3JKrUQnjQonDxLcUQnqFa5D7NA5YveqcifJmCbBBnQvE5iEVFl9tWH3 JQCFWDM7kp3g+oqzQt+OzqBS1Gf7G+Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1740661975; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0Jmr+rx5SptwuFQQlY/5oQ70jGVx0YKjoc9pywPeMs0=; b=txFsR+/b4sEQVdG1nr8Jjd0zoOCC/hP6QLPi8A0V+rSAeDdJ6nFG+hfRsxlv7WgUZ7tXYg zIVQhbOcgdSIVUCw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="q/yLe0/s"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="txFsR+/b" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1740661975; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0Jmr+rx5SptwuFQQlY/5oQ70jGVx0YKjoc9pywPeMs0=; b=q/yLe0/saIQabE3ziB3fJwCC26HCLdW09bjj2O7Tv+wSH2UfvfcObzKZmk2I8fm/Jx59zO ALzd+C0FreMuSdA3JKrUQnjQonDxLcUQnqFa5D7NA5YveqcifJmCbBBnQvE5iEVFl9tWH3 JQCFWDM7kp3g+oqzQt+OzqBS1Gf7G+Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1740661975; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0Jmr+rx5SptwuFQQlY/5oQ70jGVx0YKjoc9pywPeMs0=; b=txFsR+/b4sEQVdG1nr8Jjd0zoOCC/hP6QLPi8A0V+rSAeDdJ6nFG+hfRsxlv7WgUZ7tXYg zIVQhbOcgdSIVUCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 52F8C13888; Thu, 27 Feb 2025 13:12:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id iA6/EtdkwGdcXAAAD6G6ig (envelope-from ); Thu, 27 Feb 2025 13:12:55 +0000 Message-ID: <47dd9357-b15d-4568-8701-97b15f941475@suse.de> Date: Thu, 27 Feb 2025 14:12:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] gdb/dwarf: fix failed assertion in dwarf2_find_containing_comp_unit selftest To: Simon Marchi , gdb-patches@sourceware.org References: <20250226165255.25737-1-simon.marchi@efficios.com> <20250226165255.25737-2-simon.marchi@efficios.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <20250226165255.25737-2-simon.marchi@efficios.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 68E871F38F X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2/26/25 17:52, Simon Marchi wrote: > Commit 2f0521c0d6f6 ("gdb/dwarf: fix signature_type created with nullptr > section") added some asserts in the dwarf2_per_cu_data constructor to > verify that the passed dwarf2_per_bfd and dwarf2_section_info are not > nullptr. However, the dummy dwarf2_per_cu_data objects create the in > dwarf2_find_containing_comp_unit selftests are passed nullptr for those > parameters. > > I prefer to keep the asserts in place, as protection for the non-test > code and as self documentation, so fix this by passing some dummy > pointers in the test. > Hi Simon, I"ve applied the series, and confirmed that gdb.gdb/unittest.exp passes again. LGTM. Reviewed-By: Tom de Vries Thanks, - Tom > Change-Id: Ic7cdc1b976f7506041b651222234eefc998e473a > --- > gdb/dwarf2/read.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c > index 2b060959c36f..59d79af004ca 100644 > --- a/gdb/dwarf2/read.c > +++ b/gdb/dwarf2/read.c > @@ -20946,9 +20946,16 @@ namespace find_containing_comp_unit { > static void > run_test () > { > - const auto create_dummy_per_cu = [] (sect_offset sect_off, unsigned int length) > + char dummy_per_bfd; > + char dummy_section; > + > + const auto create_dummy_per_cu = [&] (sect_offset sect_off, > + unsigned int length) > { > - return dwarf2_per_cu_data_up (new dwarf2_per_cu_data (nullptr, nullptr, > + auto per_bfd = reinterpret_cast (&dummy_per_bfd); > + auto section = reinterpret_cast (&dummy_section); > + > + return dwarf2_per_cu_data_up (new dwarf2_per_cu_data (per_bfd, section, > sect_off, length)); > }; >