From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wihWAk3td2gYpjYAWB0awg (envelope-from ) for ; Wed, 16 Jul 2025 14:19:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1752689996; bh=9x1wzdP5RGtCQrFAwuL2FKyjRqq5R72wxafXumzDPfY=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=gWMizsSO6F5PZFpy20u7J+Rd2FHlhaJaC3WX/XL6rbWRB43PqnNl/p9T74IZleunU JLMW5iIE27JvNzORxi+pJj52m1jwbFWZrBq7TnB4BzB+3mQt1pG+fbRnm5WMg5SRVa 2cAxAAWANjGas2Nrf0rBCAfOmS21tRfHcGM3TPXU= Received: by simark.ca (Postfix, from userid 112) id EE4F21E11C; Wed, 16 Jul 2025 14:19:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=unavailable autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=s8VWyZkM; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=s8VWyZkM; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6167D1E089 for ; Wed, 16 Jul 2025 14:19:56 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E45463857732 for ; Wed, 16 Jul 2025 18:19:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E45463857732 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=s8VWyZkM; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=s8VWyZkM Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id F1A463857B90 for ; Wed, 16 Jul 2025 18:19:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F1A463857B90 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F1A463857B90 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752689964; cv=none; b=megGP43gvmV0iLuAwIFBivE9kzL+Fnzfeo77MtLR3HLyUlmZ22G4X8NwqbXk2gKEIGZ0G4u/rEfRNBOe2DX+CriHhmPgcMaVAv+fxBBcxAxUDT4s17ZD0w0u17UIgM2RAJ0+EJDh3c01sPFX1v7uQid+QMPOuPY8YjgrmL41vUc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752689964; c=relaxed/simple; bh=9x1wzdP5RGtCQrFAwuL2FKyjRqq5R72wxafXumzDPfY=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=sQ1zyB1heWDVqKWvFJOg59vjUmYD3oIr9xfg9kCRPE9yixAJsNU6PitkPBkeHk94lh05275p+elvH39sEM3r0ON4X4spleyKPEI9AWO7j2jKoeduiD8/Liuq5oFrGbrPGtn9dTglVFJlzJ4r+cZgCmD8ETwX78xSMYRGUMU6p3I= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F1A463857B90 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1752689963; bh=9x1wzdP5RGtCQrFAwuL2FKyjRqq5R72wxafXumzDPfY=; h=Date:Subject:To:References:From:In-Reply-To:From; b=s8VWyZkMt+H4pZvEPWHNNmXk5lW9MPACqjPGBe0kXcIWZFgcdT91U9CtPOTJLXQZ1 TkBwk4CiLYpndyBOJmI0jVVUGEBco6X3cIDC1s+n7x9OVeYYSC2jBWueLHQaJzJ6f+ ZpEG/UR6e9n8M5LtomyCQNyh7aGnBIeJFaPvC3Eo= Received: by simark.ca (Postfix, from userid 112) id B6C091E11C; Wed, 16 Jul 2025 14:19:23 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1752689963; bh=9x1wzdP5RGtCQrFAwuL2FKyjRqq5R72wxafXumzDPfY=; h=Date:Subject:To:References:From:In-Reply-To:From; b=s8VWyZkMt+H4pZvEPWHNNmXk5lW9MPACqjPGBe0kXcIWZFgcdT91U9CtPOTJLXQZ1 TkBwk4CiLYpndyBOJmI0jVVUGEBco6X3cIDC1s+n7x9OVeYYSC2jBWueLHQaJzJ6f+ ZpEG/UR6e9n8M5LtomyCQNyh7aGnBIeJFaPvC3Eo= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D1D431E089; Wed, 16 Jul 2025 14:19:22 -0400 (EDT) Message-ID: <47c67727-2c45-403d-9a72-4d38eb4062e1@simark.ca> Date: Wed, 16 Jul 2025 14:19:22 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: mark the start of each gdb.in.* log file To: Andrew Burgess , gdb-patches@sourceware.org References: <645cd54b3add6e39d3c8ba69e15c0a85bd0875c4.1752689517.git.aburgess@redhat.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <645cd54b3add6e39d3c8ba69e15c0a85bd0875c4.1752689517.git.aburgess@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-07-16 14:12, Andrew Burgess wrote: > Emit a line in the gdb.log file each time a new gdb.in.NUM command log > is started. The gdb.log line includes the full filename for the new > gdb.in.NUM file. > > This change will make it trivial to go from a FAIL in the gdb.log file > to the gdb.in.NUM file that (should) reproduce the failure. When I > encounter a failing test one of my first steps is usually to identify > the gdb.in.NUM file and try re-running it to see if that reproduces > the failure. Some test create many very similar gdb.in.NUM files, so > finding the exact one can sometimes be difficult. With this patch > that task is now trivial. > > There should be no change in what is tested after this commit. > --- > gdb/testsuite/lib/gdb.exp | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 777d64d14d1..78356bf51f0 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -9990,6 +9990,10 @@ proc gdb_stdin_log_init { } { > > set logfile [standard_output_file_with_gdb_instance gdb.in] > set in_file [open $logfile w] > + > + verbose -log "" > + verbose -log "Starting logfile: $logfile" > + verbose -log "" > } > > # Write to the file for logging gdb input. > > base-commit: 1edefea39ff27ed2d4aed4e45ed416f3fbaf6098 Sounds like a good idea to me. Approved-By: Simon Marchi Simon