From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id t0WVLA4Ia2nYLAcAWB0awg (envelope-from ) for ; Fri, 16 Jan 2026 22:54:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1768622094; bh=v0dFIslbOqCv28ip9+bpC4K9cxHRV42I1kbgav9C4VY=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=tttBV0Q/Rivv8FIP0s9JUcE07dv8QSZH06TDdANJRz1kpjFF4SCopnByWQ7TJ4GsK VuoaxaDrkcLUgWtIP9s2H2e5vEe2ZX6+o6L3/2tAHci5F6NdDX/Sgz2+T9ntdMhCwG KJurFpHAN5QJ6q2AMNPCLjQL1Z5I0i0O5dV/2moM= Received: by simark.ca (Postfix, from userid 112) id A95111E0DD; Fri, 16 Jan 2026 22:54:54 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=R3XWDKmH; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2F45F1E08D for ; Fri, 16 Jan 2026 22:54:54 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 9BA414BA2E34 for ; Sat, 17 Jan 2026 03:54:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9BA414BA2E34 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=R3XWDKmH Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 672554BA2E2B for ; Sat, 17 Jan 2026 03:54:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 672554BA2E2B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 672554BA2E2B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768622068; cv=none; b=ED2U+LhNpXim1bwiSh7+LCbwZdJqZvsWqYsGV4zfBiRSoXRVX9iQ8aWLKq4HToJs3I4QYn4+bsy+pKiod8Of0dVMoS4QgvgLZCoy28RpItwwPu7xJlWR7JhPuiW6QtuBKw9KQ+xTgyj8QVkmfWsdiFsd3hrMokq3myRRRNb3jg4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768622068; c=relaxed/simple; bh=v0dFIslbOqCv28ip9+bpC4K9cxHRV42I1kbgav9C4VY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=F6M1RalqfSWFRci2aNIcAbDvqqz5qISsRdLr6l6DmN/AHV76g/EPPgXv+RjDcGxl8/MJYIefmzZ7/ucmlf6C7dYjPtz3S+8jhhVj0HS7DEYo1HctHxqhLQjO4JEmnyiWDPj8yn0gHQAnQw1lar0b1FsoEPADxQAbWKpSft8GlkQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 672554BA2E2B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1768622067; bh=v0dFIslbOqCv28ip9+bpC4K9cxHRV42I1kbgav9C4VY=; h=Date:Subject:To:References:From:In-Reply-To:From; b=R3XWDKmHaAhp/vrILN0STUM+HTEjm05TB3DWBS/4A9I2zklhPiXDY4HgZrzzYBrjG EwbSy90PWKSqq8NTLue0cfOQFZFS763Tb0oIMlircu6kXyTYhcDM8I7HU+IrA5rtb8 2+VW/S8iFZ5Aw54J6tYrWBrP8y7fQWYMIWvIiouY= Received: by simark.ca (Postfix) id BCC731E08D; Fri, 16 Jan 2026 22:54:27 -0500 (EST) Message-ID: <47c0bc39-4845-43d2-b517-d430487255a5@simark.ca> Date: Fri, 16 Jan 2026 22:54:27 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/10] Fix indentation in coffread.c To: Tom Tromey , gdb-patches@sourceware.org References: <20260116-coffread-cleanups-v1-0-4d46090fad69@adacore.com> <20260116-coffread-cleanups-v1-3-4d46090fad69@adacore.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20260116-coffread-cleanups-v1-3-4d46090fad69@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-01-16 14:11, Tom Tromey wrote: > A couple of spots in coffread.c were indented incorrectly. > --- > gdb/coffread.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/gdb/coffread.c b/gdb/coffread.c > index b0c4a073df3..eaaebd55326 100644 > --- a/gdb/coffread.c > +++ b/gdb/coffread.c > @@ -69,15 +69,15 @@ static int pe_file; > /* Simplified internal version of coff symbol table information. */ > > struct coff_symbol > - { > - const char *c_name; > - int c_naux; /* 0 if syment only, 1 if syment + > +{ > + const char *c_name; > + int c_naux; /* 0 if syment only, 1 if syment + > auxent, etc. */ While at it, I think you could move the comment so it is above the field it is describing. We don't really do this style of comment to the right nowadays. Simon