From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8h9LIPsZLGobUgMAWB0awg (envelope-from ) for ; Fri, 12 Jun 2026 10:38:51 -0400 Received: by simark.ca (Postfix, from userid 112) id 723641E070; Fri, 12 Jun 2026 10:38:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E94151E070 for ; Fri, 12 Jun 2026 10:38:50 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7335E4B99F58 for ; Fri, 12 Jun 2026 14:38:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7335E4B99F58 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by sourceware.org (Postfix) with ESMTPS id CDDA04BA2E26 for ; Fri, 12 Jun 2026 14:38:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CDDA04BA2E26 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CDDA04BA2E26 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781275107; cv=none; b=Jpr80TwenTl8m3EkEFn0+iYSRgQlczugLllgCnGFg6DTzJSWEHYCmkVhmTHkTA3YUyfgVldhzynZO4PmzbtndqLolQwJh1m+noaRothEyqos87ushDfDy+lvAnDT4sqhI0zntfxKH0vQ4nS1Ag6l0y7KildE2B9O6QawhDfoN6w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781275107; c=relaxed/simple; bh=yIoOqKjdPkuDxbnaewfx21/nvlAAYlmY1liq9w0l4fk=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=blIom29meAcehhUBKCAjNIiCZDk/B+VQRkOz4H98gn1mqBTzYjWaseAj7pDsON8t5y9MCZSVl8FNJk+T0fENNzds6pVId2eIwAaKsHSq8pXFczt85NGNuJ4NYlF2y3KDs7wEa/H0gzpg55Xoc5d8bmTY6lpNG8EocYkPAyymet0= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CDDA04BA2E26 Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-45fd45e596cso602911f8f.1 for ; Fri, 12 Jun 2026 07:38:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781275106; x=1781879906; h=content-transfer-encoding:in-reply-to:content-language:from :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yKgsPbIqsZYqoSzIVtHq5mMIV490nBg+qfLRqW2sg0k=; b=VVTTLhwHQI1HE2hRwQizmOxvdOe/fyQeH5ncpi443XjneuWNnoZ8YwFG+yw0AmXCyT Hb7H8LlA7Ojfc12kW5UpPCagTRw4qFFC8/lRU+l++iljrSsaHfRRWBmc462ZQf0FkHl7 13DhgO99Xbbm6P3HA1PfAHOrEcgHK611Qt1/vZJrmWO+rzJS2qml7FyJCmHt3JPhUETc EhvyU4Wq4HIOhHXvJH8+tTY+h6hKH237dXfWzaRF1ov9OPjLpyONjsb1lo4mPncbkccG 3m+otoCWsry3zbowmE2kZmep4ez4lDe/X36fW9HrpA+zQh8ShlJiaYiH+pk9lZ7XeqDc GESA== X-Forwarded-Encrypted: i=1; AFNElJ/mMwcCoHMGImA+9k1Mp3h/005Nw1799Kr/ERxt/jhM/6OlgdjzAUcTu81WtDpU36zxXomO9okoTZu6Dw==@sourceware.org X-Gm-Message-State: AOJu0Yyp5aQ6geI1+V12O/vh8zetDHVsjbyVcuwzvb1cA9ONdu4h51bX XV7ku5pzIX8GDMcQGjjfJMs1J+aKlp4r36/Ha3uDxcB+RsZp57sUQfbwJ+ErzQ== X-Gm-Gg: Acq92OHXcjnlNQRphCOVjUUKXo/cKrnFteVdOf4HvYJ0keNRvF2mB1BFR7tH1hv6yld q2bE6iQEhz4J2cJLScG9BKMPWHlJM+GPNX46yNX8NsREPPTVA1K24cpY95KvwE/fLYW3CGv+cQC RmRt78eL1CxH6+2nJZFY8ILEgmnU052RK1GYamsAGOYZFekcgmtrPuDv3VlJZnwiGOKJE/IC4Le 0mkkP1HyzlXGcwxRxkBIxhuhcLFHjh3i+nYP+uIxj1dyBuI4Dser/5c3+UxltFKVuodWCMSv1gr 1ft/UiPsW06eB8GC0YIT3JznrfaVfeudYRfMhyMCMd22vvskKnm1Eby6a0+EIigYBvkb1sROvTd gRk2PtgXb8k12Ple00VR8e0R3s732sYh6kY5j3Q7c+OFBPvfm9DVkrvSJ9NIJ2J6vcZm3y1q9Fv AXX6Oaph6oZhQ1Jklh81rYBAXXfufP/nLeIrHc2S1fyFbCpqsBwp5005d5rUrYO0vgGw== X-Received: by 2002:a05:6000:4283:b0:454:a41f:d082 with SMTP id ffacd0b85a97d-4606da5712cmr4931666f8f.3.1781275105413; Fri, 12 Jun 2026 07:38:25 -0700 (PDT) Received: from ?IPV6:2001:8a0:fae3:2600:bf49:e032:9c8d:efc8? ([2001:8a0:fae3:2600:bf49:e032:9c8d:efc8]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f263923sm6576962f8f.2.2026.06.12.07.38.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jun 2026 07:38:25 -0700 (PDT) Message-ID: <47b2f267-ffcc-48a8-904c-0af5092c8df1@palves.net> Date: Fri, 12 Jun 2026 15:38:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv3] gdb/python: fix 'exited' event when GDB exits from core file debugging To: Andrew Burgess , gdb-patches@sourceware.org References: <7db5bc5d0e3c7189881540ab2c775ea20fc03b5f.1780767159.git.aburgess@redhat.com> <7b7983979dfdb856c6968729ff8a4b37d90775aa.1781000323.git.aburgess@redhat.com> From: Pedro Alves Content-Language: en-US In-Reply-To: <7b7983979dfdb856c6968729ff8a4b37d90775aa.1781000323.git.aburgess@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, On 2026-06-09 11:19, Andrew Burgess wrote: > +int > +main (void) > +{ > + alarm (300); Can you use gdb_watchdog, please? It'll make this work on Windows too, in theory. At least, the non-core parts of the tests. > +# Load the Python script for this test. Record the string > +# representation of the current inferior. Then exit GDB. Ensure that > +# during the exit we see a single Python 'exited' event associated > +# with the expected inferior. > +proc source_py_script_and_exit_checking_event {} { > + gdb_test_no_output "source $::remote_python_file" \ > + "load python script" > + > + set expected_inferior_string \ > + [capture_command_output \ > + "python print(str(gdb.selected_inferior()))" ""] > + > + set inferior_string "" > + set event_count 0 > + gdb_test_multiple "with confirm off -- exit" "exit gdb" { ... > + > + -re "^\[^\r\n\]*\r\n" { > + exp_continue > + } This looks like could use "-lbl". Otherwise LGTM. Approved-by: Pedro Alves