From: Jan Vrany <jan.vrany@fit.cvut.cz>
To: gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>
Subject: Re: [PING] [PATCH v5] Fix segfault when invoking -var-info-path-expression on a dynamic varobj
Date: Tue, 31 Jul 2018 09:14:00 -0000 [thread overview]
Message-ID: <47a18fed06b28c4b2ef602f52ec247f527b3aa54.camel@fit.cvut.cz> (raw)
In-Reply-To: <878t5s655q.fsf@tromey.com>
On Mon, 2018-07-30 at 10:48 -0600, Tom Tromey wrote:
> > > + Copyright (C) 1999-2018 Free Software Foundation, Inc.
> > > +# Copyright (C) 2008-2018 Free Software Foundation, Inc.
> > > +# Copyright (C) 2008-2018 Free Software Foundation, Inc.
>
> These dates look weird. I assume you copied the headers from elsewhere
> -- a time-honored tradition. However if the files don't substantially
> share anything with other files, I think just 2018 should suffice.
>
Oops, you're right, I just copy-pasted the header from other files and
forgot to fix. I'd say these files are completely new, though indeed
I took an inspiration from other files to see how to write a test.
> This is ok with this either fixed, or if there's some overlap, an email
> to that effect.
Fixed patch will follow shortly.
Thanks, Jan
prev parent reply other threads:[~2018-07-31 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 19:21 Jan Vrany
2018-07-25 12:33 ` [PING] " Jan Vrany
2018-07-30 16:49 ` Tom Tromey
2018-07-30 19:53 ` Simon Marchi
2018-07-31 9:14 ` Jan Vrany [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47a18fed06b28c4b2ef602f52ec247f527b3aa54.camel@fit.cvut.cz \
--to=jan.vrany@fit.cvut.cz \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox