From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16540 invoked by alias); 8 Apr 2008 11:34:33 -0000 Received: (qmail 16335 invoked by uid 22791); 8 Apr 2008 11:34:08 -0000 X-Spam-Check-By: sourceware.org Received: from mail3.nsc.com (HELO sc-mailgw01.nsc.com) (12.151.32.18) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 08 Apr 2008 11:33:31 +0000 X-WSS-ID: 0JZ083O-07-10S-01 Received: from SCNTRDCSS7.nsc.com (emf.nsc.com [192.168.7.29]) by sc-mailgw01.nsc.com (Tumbleweed MailGate 3.5.1) with ESMTP id 241771D8657E for ; Tue, 8 Apr 2008 04:33:23 -0700 (PDT) Received: from [10.188.132.130] by SCNTRDCSS6.nsc.com with ESMTP (-Hi-); Tue, 08 Apr 2008 04:33:22 -0700 X-Server-Uuid: CDE0D3F6-4EC6-4DC9-81EF-DBBF12AF9A3C Received: from [139.187.78.222] by scmh1.nsc.com with ESMTP; Tue, 8 Apr 2008 04:33:22 -0700 Message-ID: <47FB58EB.8080408@nsc.com> Date: Tue, 08 Apr 2008 12:03:00 -0000 From: "M R Swami Reddy" User-Agent: Thunderbird 2.0.0.12 (Windows/20080213) MIME-Version: 1.0 To: "Hans-Peter Nilsson" cc: gdb-patches@sourceware.org Subject: Re: Your sim testsuite changes broke other targets References: <200804081116.m38BGwGH032650@ignucius.se.axis.com> In-Reply-To: <200804081116.m38BGwGH032650@ignucius.se.axis.com> X-WSS-ID: 6BE5885514O1033528-06-01 Content-Type: multipart/mixed; boundary=------------080002080409090902000106 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00148.txt.bz2 This is a multi-part message in MIME format. --------------080002080409090902000106 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-length: 1262 Hi, Opps, sorry for this. Fixed this issue. Please find the attached patch file and let me know if this ok to apply? ChangeLog: ==== 2008-04-08 M R Swami Reddy * allinsn.exp: Moved target_alias and global_ld_options into if condition ==== Thanks, Swami Hans-Peter Nilsson wrote: > All tests broke for all targets in my sim autotester. For > *some* reason, they now want to run cr16-elf-as for the tests... > > 2008-02-12 M Ranga Swami Reddy > > * sim/cr16/: New directory. Tests for CR16 simulator. > sim/cr16/allinsn.exp and sim/cr16/misc.exp: New files: Test scripts. > > At the top of that allinsn.exp: > > ------ > # CR16 simulator testsuite. > > set target_alias cr16-elf > set global_ld_options "-L/local/user/swami/cr16-5.1/build/CR_R_2007-08-24_11-34-56/release/linux/lib/gcc/cr16-elf/4.1.2 -T/home10/swami/dummy.ld" > > if [istarget cr16*-*-*] { > ... > ------ > > I think I see why! (Hint: they aren't cr16-elf. ;) > > Did you really mean to commit with those "set"s there? Please > remove them; they look wrong. At least move them inside the > "if". (If you remove them, I'll consider adding cr16 to the > targets I test in my autotester.) > > brgds, H-P > --------------080002080409090902000106 Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename=allinsn.exp.patch Content-Type: text/plain; name=allinsn.exp.patch Content-length: 896 Index: allinsn.exp =================================================================== RCS file: /cvs/src/src/sim/testsuite/sim/cr16/allinsn.exp,v retrieving revision 1.1 diff -c -r1.1 allinsn.exp *** allinsn.exp 8 Apr 2008 09:03:17 -0000 1.1 --- allinsn.exp 8 Apr 2008 11:29:10 -0000 *************** *** 1,7 **** # CR16 simulator testsuite. - set target_alias cr16-elf - set global_ld_options "-L/local/user/swami/cr16-5.1/build/CR_R_2007-08-24_11-34-56/release/linux/lib/gcc/cr16-elf/4.1.2 -T/home10/swami/dummy.ld" if [istarget cr16*-*-*] { # load support procs --- 1,5 ---- *************** *** 10,15 **** --- 8,16 ---- # all machines set all_machs "cr16" + set target_alias cr16-elf + set global_ld_options "-T$srcdir/$subdir/dummy.ld" + # The .cgs suffix is for "cgen .s". foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.cgs]] { --------------080002080409090902000106--