Re: [patch] Remove comments from user_code in gdb_test_multiple

Markus Deuling
2008-03-31T08:42:36Z

Ulrich Weigand schrieb:
> Markus Deuling wrote:
>
>> diff -urpN src/gdb/testsuite/gdb.arch/spu-info.exp dev/gdb/testsuite/gdb.arch/spu-info.exp
>> --- src/gdb/testsuite/gdb.arch/spu-info.exp 2008-01-01 23:53:18.000000000 +0100
>> +++ dev/gdb/testsuite/gdb.arch/spu-info.exp 2008-03-28 09:53:47.000000000 +0100
>> @@ -200,9 +200,17 @@ gdb_test "finish" "" "finish"
>> # Mailbox Test
>> # 'info spu mailbox' should be empty.
>> c_to "Marker Mbox"
>> -gdb_test "info spu mailbox" \
>> - "SPU Outbound Mailbox.*0xc0000000.*SPU Outbound Interrupt Mailbox.*0xc0000000.*" \
>> - "info spu mailbox"
>> +set msg "info spu mailbox"
>> +gdb_test_multiple "info spu mailbox" $msg {
>> + -re "SPU Outbound Mailbox.*0x00000000.*SPU Outbound Interrupt Mailbox.*0x00000000.*$gdb_prompt $" {
>> + pass $msg
>> + }
>> + -re "SPU Outbound Mailbox.*0x.*SPU Outbound Interrupt Mailbox.*0x.*$gdb_prompt $" {
>> + # Older kernels had a bug that caused them to return arbitrary values
>> + # when attempting to read from an empty mailbox via spufs.
>> + xfail $msg
>> + }
>> +}
>>
>> # 'info spu mailbox' should now contain data.
>> c_to "Marker MboxEnd"
>
>
> Assuming you tested the behaviour on both old and new kernels,
> this is OK with me.

2.6.20-be0707.1.20070220:
(gdb) XFAIL: gdb.arch/spu-info.exp: info spu mailbox

2.6.22-5.20070821bsc
PASS: gdb.arch/spu-info.exp: info spu mailbox

Committed now with following ChangeLog, thanks.

ChangeLog:

2008-03-31 Markus Deuling <deuling@de.ibm.com>
Ulrich Weigand <Ulrich.Weigand@de.ibm.com>

* gdb.arch/spu-info.exp (info spu mailbox): Check for correct initial
value. Add xfail for older kernels.

--
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com