From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29861 invoked by alias); 31 Mar 2008 08:42:36 -0000 Received: (qmail 29851 invoked by uid 22791); 31 Mar 2008 08:42:35 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 31 Mar 2008 08:42:14 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.13.8/8.13.8) with ESMTP id m2V8gAug176050 for ; Mon, 31 Mar 2008 08:42:10 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m2V8gAH23227660 for ; Mon, 31 Mar 2008 10:42:10 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m2V8g9e1029692 for ; Mon, 31 Mar 2008 10:42:09 +0200 Received: from bbkeks.de.ibm.com (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m2V8g8r4029618 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 31 Mar 2008 10:42:09 +0200 Message-ID: <47F0A3E0.1090302@de.ibm.com> Date: Mon, 31 Mar 2008 08:42:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.12 (X11/20080213) MIME-Version: 1.0 To: Ulrich Weigand CC: Daniel Jacobowitz , GDB Patches Subject: Re: [patch] Remove comments from user_code in gdb_test_multiple References: <200803281559.m2SFxbIA006282@d12av02.megacenter.de.ibm.com> In-Reply-To: <200803281559.m2SFxbIA006282@d12av02.megacenter.de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00498.txt.bz2 Ulrich Weigand schrieb: > Markus Deuling wrote: > >> diff -urpN src/gdb/testsuite/gdb.arch/spu-info.exp dev/gdb/testsuite/gdb.arch/spu-info.exp >> --- src/gdb/testsuite/gdb.arch/spu-info.exp 2008-01-01 23:53:18.000000000 +0100 >> +++ dev/gdb/testsuite/gdb.arch/spu-info.exp 2008-03-28 09:53:47.000000000 +0100 >> @@ -200,9 +200,17 @@ gdb_test "finish" "" "finish" >> # Mailbox Test >> # 'info spu mailbox' should be empty. >> c_to "Marker Mbox" >> -gdb_test "info spu mailbox" \ >> - "SPU Outbound Mailbox.*0xc0000000.*SPU Outbound Interrupt Mailbox.*0xc0000000.*" \ >> - "info spu mailbox" >> +set msg "info spu mailbox" >> +gdb_test_multiple "info spu mailbox" $msg { >> + -re "SPU Outbound Mailbox.*0x00000000.*SPU Outbound Interrupt Mailbox.*0x00000000.*$gdb_prompt $" { >> + pass $msg >> + } >> + -re "SPU Outbound Mailbox.*0x.*SPU Outbound Interrupt Mailbox.*0x.*$gdb_prompt $" { >> + # Older kernels had a bug that caused them to return arbitrary values >> + # when attempting to read from an empty mailbox via spufs. >> + xfail $msg >> + } >> +} >> >> # 'info spu mailbox' should now contain data. >> c_to "Marker MboxEnd" > > > Assuming you tested the behaviour on both old and new kernels, > this is OK with me. 2.6.20-be0707.1.20070220: (gdb) XFAIL: gdb.arch/spu-info.exp: info spu mailbox 2.6.22-5.20070821bsc PASS: gdb.arch/spu-info.exp: info spu mailbox Committed now with following ChangeLog, thanks. ChangeLog: 2008-03-31 Markus Deuling Ulrich Weigand * gdb.arch/spu-info.exp (info spu mailbox): Check for correct initial value. Add xfail for older kernels. -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com