From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11061 invoked by alias); 28 Mar 2008 09:16:27 -0000 Received: (qmail 11051 invoked by uid 22791); 28 Mar 2008 09:16:27 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 28 Mar 2008 09:16:05 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.13.8/8.13.8) with ESMTP id m2S9G3dL177176 for ; Fri, 28 Mar 2008 09:16:03 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m2S9G2sg3481762 for ; Fri, 28 Mar 2008 10:16:03 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m2S9G25f014808 for ; Fri, 28 Mar 2008 10:16:02 +0100 Received: from bbkeks.de.ibm.com (sig-9-146-226-69.de.ibm.com [9.146.226.69]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m2S9FxhY014668 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 28 Mar 2008 10:16:01 +0100 Message-ID: <47ECB74F.9020501@de.ibm.com> Date: Fri, 28 Mar 2008 09:16:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.12 (X11/20080213) MIME-Version: 1.0 To: Ulrich Weigand CC: Daniel Jacobowitz , GDB Patches Subject: Re: [patch] Remove comments from user_code in gdb_test_multiple References: <200803271751.m2RHpwJj005352@d12av02.megacenter.de.ibm.com> In-Reply-To: <200803271751.m2RHpwJj005352@d12av02.megacenter.de.ibm.com> Content-Type: multipart/mixed; boundary="------------040305010508010305070105" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00457.txt.bz2 This is a multi-part message in MIME format. --------------040305010508010305070105 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 605 Ulrich Weigand schrieb: > Daniel Jacobowitz wrote: > >> That becomes: >> >>> -re "SPU Outbound Mailbox.*0x.*SPU Outbound Interrupt Mailbox.*0x.*$gdb_prompt $" { >>> # Older kernels had a bug that caused them to return arbitrary values when >>> # attempting to read from an empty mailbox via spufs. >>> xfail "$msg" >>> } > > I agree that this seems the best solution -- I wasn't trying to > do anything special, I just didn't think of the where exactly > to place the comment ... Here is a new version. Ok ? -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com --------------040305010508010305070105 Content-Type: text/plain; name="fix-spu-mailbox" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="fix-spu-mailbox" Content-length: 1050 diff -urpN src/gdb/testsuite/gdb.arch/spu-info.exp dev/gdb/testsuite/gdb.arch/spu-info.exp --- src/gdb/testsuite/gdb.arch/spu-info.exp 2008-01-01 23:53:18.000000000 +0100 +++ dev/gdb/testsuite/gdb.arch/spu-info.exp 2008-03-28 09:53:47.000000000 +0100 @@ -200,9 +200,17 @@ gdb_test "finish" "" "finish" # Mailbox Test # 'info spu mailbox' should be empty. c_to "Marker Mbox" -gdb_test "info spu mailbox" \ - "SPU Outbound Mailbox.*0xc0000000.*SPU Outbound Interrupt Mailbox.*0xc0000000.*" \ - "info spu mailbox" +set msg "info spu mailbox" +gdb_test_multiple "info spu mailbox" $msg { + -re "SPU Outbound Mailbox.*0x00000000.*SPU Outbound Interrupt Mailbox.*0x00000000.*$gdb_prompt $" { + pass $msg + } + -re "SPU Outbound Mailbox.*0x.*SPU Outbound Interrupt Mailbox.*0x.*$gdb_prompt $" { + # Older kernels had a bug that caused them to return arbitrary values + # when attempting to read from an empty mailbox via spufs. + xfail $msg + } +} # 'info spu mailbox' should now contain data. c_to "Marker MboxEnd" --------------040305010508010305070105--