From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29594 invoked by alias); 27 Mar 2008 15:47:13 -0000 Received: (qmail 29494 invoked by uid 22791); 27 Mar 2008 15:47:11 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 27 Mar 2008 15:46:41 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id m2RFkctE358358 for ; Thu, 27 Mar 2008 15:46:38 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m2RFkc754108494 for ; Thu, 27 Mar 2008 16:46:38 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m2RFkcV8010846 for ; Thu, 27 Mar 2008 16:46:38 +0100 Received: from bbkeks.de.ibm.com (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m2RFkaSP010804 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 27 Mar 2008 16:46:37 +0100 Message-ID: <47EBC15C.6070306@de.ibm.com> Date: Thu, 27 Mar 2008 15:47:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.12 (X11/20080213) MIME-Version: 1.0 To: Daniel Jacobowitz , Ulrich Weigand CC: GDB Patches Subject: Re: [patch] Remove comments from user_code in gdb_test_multiple References: <47EBBBFA.4010700@de.ibm.com> <20080327153159.GA8060@caradoc.them.org> In-Reply-To: <20080327153159.GA8060@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00439.txt.bz2 Daniel Jacobowitz schrieb: > On Thu, Mar 27, 2008 at 04:23:38PM +0100, Markus Deuling wrote: >> Hi, >> >> this patch removes all comments from user_code given to gdb_test_multiple. This allows >> to have comments in code snippets given to gdb_test_multiple like for exmaple proposed >> in this patch: >> >> http://sourceware.org/ml/gdb-patches/2008-03/msg00290.html >> >> >> ChangeLog: >> >> * lib/gdb.exp (gdb_test_multiple): Remove comments from user_code. >> >> Ok ? > > Won't this eat quoted # signs in the middle of patterns? > I suggest you move the comment inside the code block where it would be > valid, instead. > Hm, your're right. They're eaten :-( S.th. like this isn't possible currently. Moving this comment above gdb_test_multiple might be confusing (there might be a lot more re's with different meanings): gdb_test_multiple "info spu mailbox" "$msg" { -re "SPU Outbound Mailbox.*0x00000000.*SPU Outbound Interrupt Mailbox.*0x00000000.*$gdb_prompt $" { pass "$msg" } # Older kernels had a bug that caused them to return arbitrary values when # attempting to read from an empty mailbox via spufs. -re "SPU Outbound Mailbox.*0x.*SPU Outbound Interrupt Mailbox.*0x.*$gdb_prompt $" { xfail "$msg" } } What do you think about the spu info mailbox patch then ? Move the comment above gdb_test_multiple ? Or use send_gdb/gdb_expect and have the comments in the right place? -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com