From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13180 invoked by alias); 20 Mar 2008 15:31:11 -0000 Received: (qmail 13172 invoked by uid 22791); 20 Mar 2008 15:31:10 -0000 X-Spam-Check-By: sourceware.org Received: from igw3.br.ibm.com (HELO igw3.br.ibm.com) (32.104.18.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 20 Mar 2008 15:30:45 +0000 Received: from mailhub3.br.ibm.com (unknown [9.18.232.110]) by igw3.br.ibm.com (Postfix) with ESMTP id B3DF83900F4 for ; Thu, 20 Mar 2008 12:19:01 -0300 (BRST) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m2KFUg1K4436186 for ; Thu, 20 Mar 2008 12:30:42 -0300 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m2KFUfHT018222 for ; Thu, 20 Mar 2008 12:30:41 -0300 Received: from [9.8.12.46] ([9.8.12.46]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m2KFUf1L018128; Thu, 20 Mar 2008 12:30:41 -0300 Message-ID: <47E28321.3070102@linux.vnet.ibm.com> Date: Thu, 20 Mar 2008 15:31:00 -0000 From: Carlos Eduardo Seo User-Agent: Thunderbird 2.0.0.12 (X11/20080319) MIME-Version: 1.0 To: Ulrich Weigand CC: GDB Patches Mailing List Subject: Re: [RFC] Add support for PPC Altivec registers in gcore References: <200803171906.m2HJ6YCB030691@d12av02.megacenter.de.ibm.com> In-Reply-To: <200803171906.m2HJ6YCB030691@d12av02.megacenter.de.ibm.com> OpenPGP: id=8BFFA900 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00296.txt.bz2 Thanks for the review. I already corrected the points you mentioned. One thing remains: Ulrich Weigand wrote: >> Index: src/gdb/arch-utils.h > >> +#include "regset.h" >> struct gdbarch; >> struct frame_info; >> struct minimal_symbol; >> struct type; >> struct gdbarch_info; >> >> +extern struct core_regset_section default_regset_sections[]; > > I'd prefer *not* to include a new header file here; a forward > declaration of the struct should be enough: > struct core_regset_section; A forward declaration here doesn't seem to work. Any ideas? -- Carlos Eduardo Seo Software Engineer IBM Linux Technology Center