From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9301 invoked by alias); 19 Mar 2008 18:50:53 -0000 Received: (qmail 9292 invoked by uid 22791); 19 Mar 2008 18:50:52 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.29.153) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Mar 2008 18:50:29 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.13.8/8.13.8) with ESMTP id m2JIoQ3E035094 for ; Wed, 19 Mar 2008 18:50:26 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m2JIoQ8k1990756 for ; Wed, 19 Mar 2008 19:50:26 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m2JIoPkB032601 for ; Wed, 19 Mar 2008 19:50:26 +0100 Received: from bbkeks.de.ibm.com (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m2JIoOS3032582 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 19 Mar 2008 19:50:25 +0100 Message-ID: <47E16070.1080600@de.ibm.com> Date: Wed, 19 Mar 2008 18:50:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.12 (X11/20080213) MIME-Version: 1.0 To: Joel Brobecker CC: GDB Patches , Ulrich Weigand , Daniel Jacobowitz Subject: Re: [rfc] Fix info spu mailbox command References: <200803171322.m2HDMfBG006655@d12av02.megacenter.de.ibm.com> <47E01DB4.6030900@de.ibm.com> <20080318212521.GB3683@adacore.com> <47E0EAB3.5080703@de.ibm.com> <20080319115354.GA32034@caradoc.them.org> <47E154F5.10204@de.ibm.com> <20080319183220.GA3588@adacore.com> In-Reply-To: <20080319183220.GA3588@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00286.txt.bz2 Joel Brobecker schrieb: > Hi Markus, > >> +set msg "info spu mailbox" >> +gdb_test_multiple "info spu mailbox " $msg { >> + -re "SPU Outbound Mailbox.*0x00000000.*SPU Outbound Interrupt Mailbox.*0x00000000.*$gdb_prompt $" \ >> + { pass $msg } >> + default { >> + xfail $msg >> + } >> +} > > After having looked at your previous patch, it looks like you probably > wanted to only xfail the test when the 0x number (mailbox number?) is > 0xc0000000, but anything else is an unexpected FAIL. Also, I don't think > you need the "default" block. So I think your test should look like this: > > gdb_test_multiple "info spu mailbox" "$msg" { > -re "SPU Outbound Mailbox.*0x00000000.*SPU Outbound Interrupt Mailbox.*0x00000000.*$gdb_prompt $" { > pass "$msg" > } > -re "SPU Outbound Mailbox.*0xc0000000.*SPU Outbound Interrupt Mailbox.*0xc0000000.*$gdb_prompt $" { > xfail "$msg" > } > } > Hm, yes and no. Maybe it was not a good idea from me to check for 0xc.... Before that kernel patch the data came from an uninitialised variable so it might have been 0xc... accidently. I haven't seen cases != 0xc but this does not mean that this can't happen. Only thing I can say for sure is that 0x00000000 should be the initial content. Everything else is XFAIL because of old kernel version. -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com