From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12556 invoked by alias); 19 Mar 2008 18:01:53 -0000 Received: (qmail 12547 invoked by uid 22791); 19 Mar 2008 18:01:52 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Mar 2008 18:01:30 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id m2JI1Rfs099460 for ; Wed, 19 Mar 2008 18:01:27 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m2JI1QMD1990856 for ; Wed, 19 Mar 2008 19:01:26 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m2JI1QAW030080 for ; Wed, 19 Mar 2008 19:01:26 +0100 Received: from bbkeks.de.ibm.com (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m2JI1PjC030074 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 19 Mar 2008 19:01:26 +0100 Message-ID: <47E154F5.10204@de.ibm.com> Date: Wed, 19 Mar 2008 18:01:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.12 (X11/20080213) MIME-Version: 1.0 To: GDB Patches CC: Joel Brobecker , Ulrich Weigand , Daniel Jacobowitz Subject: Re: [rfc] Fix info spu mailbox command References: <200803171322.m2HDMfBG006655@d12av02.megacenter.de.ibm.com> <47E01DB4.6030900@de.ibm.com> <20080318212521.GB3683@adacore.com> <47E0EAB3.5080703@de.ibm.com> <20080319115354.GA32034@caradoc.them.org> In-Reply-To: <20080319115354.GA32034@caradoc.them.org> Content-Type: multipart/mixed; boundary="------------070101020204030308000802" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00284.txt.bz2 This is a multi-part message in MIME format. --------------070101020204030308000802 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 403 Daniel Jacobowitz schrieb: > gdb_test_multiple is newer and most of the testsuite is very old, > that's why gdb_expect is used. gdb_test_multiple is much better > because it handles standard cases, like an unexpected prompt, without > having to wait for a timeout. > Attached is a version using gdb_test_multiple. Ok ? -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com --------------070101020204030308000802 Content-Type: text/plain; name="fix-spu-mailbox" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="fix-spu-mailbox" Content-length: 821 diff -urpN src/gdb/testsuite/gdb.arch/spu-info.exp dev/gdb/testsuite/gdb.arch/spu-info.exp --- src/gdb/testsuite/gdb.arch/spu-info.exp 2008-01-01 23:53:18.000000000 +0100 +++ dev/gdb/testsuite/gdb.arch/spu-info.exp 2008-03-19 18:52:48.000000000 +0100 @@ -200,9 +200,14 @@ gdb_test "finish" "" "finish" # Mailbox Test # 'info spu mailbox' should be empty. c_to "Marker Mbox" -gdb_test "info spu mailbox" \ - "SPU Outbound Mailbox.*0xc0000000.*SPU Outbound Interrupt Mailbox.*0xc0000000.*" \ - "info spu mailbox" +set msg "info spu mailbox" +gdb_test_multiple "info spu mailbox " $msg { + -re "SPU Outbound Mailbox.*0x00000000.*SPU Outbound Interrupt Mailbox.*0x00000000.*$gdb_prompt $" \ + { pass $msg } + default { + xfail $msg + } +} # 'info spu mailbox' should now contain data. c_to "Marker MboxEnd" --------------070101020204030308000802--