From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25882 invoked by alias); 11 Mar 2008 05:23:52 -0000 Received: (qmail 25872 invoked by uid 22791); 11 Mar 2008 05:23:51 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.29.153) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 11 Mar 2008 05:23:05 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.13.8/8.13.8) with ESMTP id m2B5N2mt183006 for ; Tue, 11 Mar 2008 05:23:02 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m2B5N2xa1163360 for ; Tue, 11 Mar 2008 06:23:02 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m2B5N2p4022643 for ; Tue, 11 Mar 2008 06:23:02 +0100 Received: from bbkeks.de.ibm.com (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m2B5N0NL022592 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 11 Mar 2008 06:23:02 +0100 Message-ID: <47D61734.1020306@de.ibm.com> Date: Tue, 11 Mar 2008 05:23:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.12 (X11/20080213) MIME-Version: 1.0 To: gdb-patches@sourceware.org CC: Mark Kettenis , uweigand@de.ibm.com, drow@false.org Subject: Re: [rfc] Replace x86 register macros References: <200803101213.m2ACD3aP028558@d12av02.megacenter.de.ibm.com> <200803101223.m2ACN951020082@brahms.sibelius.xs4all.nl> In-Reply-To: <200803101223.m2ACN951020082@brahms.sibelius.xs4all.nl> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00112.txt.bz2 Mark Kettenis schrieb: >> Date: Mon, 10 Mar 2008 13:13:03 +0100 (CET) >> From: "Ulrich Weigand" >> >> Markus Deuling wrote: >> >>> Thanks for review, I reworked the patch now. Ok to commit? >>> +#define I387_FCTRL_REGNUM(tdep) (I387_ST0_REGNUM(tdep) + 8) >>> +#define I387_FSTAT_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 1) >>> +#define I387_FTAG_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 2) >>> +#define I387_FISEG_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 3) >>> +#define I387_FIOFF_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 4) >>> +#define I387_FOSEG_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 5) >>> +#define I387_FOOFF_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 6) >>> +#define I387_FOP_REGNUM(tdep) (I387_FCTRL_REGNUM(tdep)+ 7) >>> +#define I387_XMM0_REGNUM(tdep) (I387_ST0_REGNUM(tdep)+ 16) >>> +#define I387_MXCSR_REGNUM(tdep) (I387_XMM0_REGNUM(tdep) \ >>> ++ I387_NUM_XMM_REGS(tdep)) >> I guess I should have been more specific about the formatting; >> this is unfortunately still not quite right: On the right-hand >> sides, you should use normal whitespace rules, i.e. spaces before >> the '(' and '+'. Also, the last line should be properly >> indented, somthing like: >> >> #define I387_MXCSR_REGNUM(tdep) (I387_XMM0_REGNUM (tdep) \ >> + I387_NUM_XMM_REGS (tdep)) > > Or better yet, something like: > > #define I387_MXCSR_REGNUM(tdep) \ > (I387_XMM0_REGNUM (tdep) + I387_NUM_XMM_REGS (tdep)) > Thank you. I've committed a corrected version now. Regards, Markus -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com