From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26456 invoked by alias); 19 Feb 2008 19:29:46 -0000 Received: (qmail 26439 invoked by uid 22791); 19 Feb 2008 19:29:45 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 19 Feb 2008 19:29:18 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.13.8/8.13.8) with ESMTP id m1JJTGaA025062 for ; Tue, 19 Feb 2008 19:29:16 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m1JJTFX02105416 for ; Tue, 19 Feb 2008 20:29:15 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m1JJTFcG009878 for ; Tue, 19 Feb 2008 19:29:15 GMT Received: from bbkeks.de.ibm.com (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m1JJTE6W009873 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 19 Feb 2008 19:29:15 GMT Message-ID: <47BB2D94.2040608@de.ibm.com> Date: Tue, 19 Feb 2008 19:29:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.9 (X11/20071031) MIME-Version: 1.0 To: GDB Patches CC: Ulrich Weigand Subject: [rfc]: Get endianess from disassemble_info Content-Type: multipart/mixed; boundary="------------090401070901020308050100" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00318.txt.bz2 This is a multi-part message in MIME format. --------------090401070901020308050100 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Content-length: 534 Hi, this patch replaces some current_gdbachs by getting the current endianess from disassemble_info instead via a gdbarch callback. Tested via gdb_buildall.sh and native on PowerPC without regression. Ok to commit ? ChangeLog: * rs6000-tdep.c (gdb_print_insn_powerpc): Get the current endianess from disassemble_info instead of gdbarch_byte_order * mips-tdep.c (gdb_print_insn_mips): Likewise. * arm-tdep.c (gdb_print_insn_arm): Likewise. -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com --------------090401070901020308050100 Content-Type: text/plain; name="diff-disasm" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diff-disasm" Content-length: 1588 diff -urpN src/gdb/arm-tdep.c dev/gdb/arm-tdep.c --- src/gdb/arm-tdep.c 2008-01-27 06:30:37.000000000 +0100 +++ dev/gdb/arm-tdep.c 2008-02-19 20:22:51.000000000 +0100 @@ -2018,7 +2018,7 @@ gdb_print_insn_arm (bfd_vma memaddr, dis else info->symbols = NULL; - if (gdbarch_byte_order (current_gdbarch) == BFD_ENDIAN_BIG) + if (info->endian == BFD_ENDIAN_BIG) return print_insn_big_arm (memaddr, info); else return print_insn_little_arm (memaddr, info); diff -urpN src/gdb/mips-tdep.c dev/gdb/mips-tdep.c --- src/gdb/mips-tdep.c 2008-01-11 14:20:52.000000000 +0100 +++ dev/gdb/mips-tdep.c 2008-02-19 20:21:15.000000000 +0100 @@ -4878,7 +4878,7 @@ gdb_print_insn_mips (bfd_vma memaddr, st info->disassembler_options = "gpr-names=32"; /* Call the appropriate disassembler based on the target endian-ness. */ - if (gdbarch_byte_order (current_gdbarch) == BFD_ENDIAN_BIG) + if (info->endian == BFD_ENDIAN_BIG) return print_insn_big_mips (memaddr, info); else return print_insn_little_mips (memaddr, info); diff -urpN src/gdb/rs6000-tdep.c dev/gdb/rs6000-tdep.c --- src/gdb/rs6000-tdep.c 2008-02-11 05:48:37.000000000 +0100 +++ dev/gdb/rs6000-tdep.c 2008-02-19 19:11:10.000000000 +0100 @@ -2929,7 +2929,7 @@ gdb_print_insn_powerpc (bfd_vma memaddr, if (!info->disassembler_options) info->disassembler_options = "any"; - if (gdbarch_byte_order (current_gdbarch) == BFD_ENDIAN_BIG) + if (info->endian == BFD_ENDIAN_BIG) return print_insn_big_powerpc (memaddr, info); else return print_insn_little_powerpc (memaddr, info); --------------090401070901020308050100--