Hi Uli, > > This is really the wrong check. It should really just verify that > no out-of-bounds access to u_offsets happens, so the line should > just be something like: > > if ((unsigned) regno >= ARRAY_SIZE (u_offsets)) > yes, you're right. This check is much better :-) I changed the patch. Ok to commit? ChangeLog: * hppa-tdep.h (find_global_pointer): Add gdbarch as parameter. * hppa-hpux-tdep.c (hppa32_hpux_find_global_pointer): Likewise. Replace current_gdbarch by gdbarch. (hppa64_hpux_find_global_pointer): Likewise. * hppa-tdep.c (hppa_find_global_pointer): Likewise. (hppa32_push_dummy_call, hppa64_push_dummy_call): Update call for find_global_pointer. * hppabsd-tdep.c (hppabsd_find_global_pointer): Add gdbarch as parameter. * hppa-linux-tdep.c (hppa_linux_find_global_pointer): Likewise. * hppa-linux-nat.c (hppa_linux_register_addr): Add gdbarch as parameter. (fetch_register, store_register): Update call for hppa_linux_register_addr. * hppa-hpux-tdep.c (hppa_hpux_sr_for_addr): Add gdbarch as parameter and replace current_gdbarch by gdbarch. (hppa_hpux_push_dummy_code): Update call for hppa_hpux_sr_for_addr. -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com