From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28862 invoked by alias); 14 Feb 2008 06:14:04 -0000 Received: (qmail 28852 invoked by uid 22791); 14 Feb 2008 06:14:03 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 14 Feb 2008 06:13:42 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.13.8/8.13.8) with ESMTP id m1E6DdON161564 for ; Thu, 14 Feb 2008 06:13:39 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m1E6DdWX2212008 for ; Thu, 14 Feb 2008 07:13:39 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m1E6Dc7l025337 for ; Thu, 14 Feb 2008 07:13:39 +0100 Received: from bbkeks.de.ibm.com (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m1E6DbWU025326 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 14 Feb 2008 07:13:38 +0100 Message-ID: <47B3DB9E.1050100@de.ibm.com> Date: Thu, 14 Feb 2008 06:14:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.9 (X11/20071031) MIME-Version: 1.0 To: Daniel Jacobowitz , GDB Patches Subject: Re: Bug in mips:3900 arch ? References: <479DEAAA.4050108@de.ibm.com> <20080131222104.GC6715@caradoc.them.org> In-Reply-To: <20080131222104.GC6715@caradoc.them.org> Content-Type: multipart/mixed; boundary="------------030407060303070106060806" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00225.txt.bz2 This is a multi-part message in MIME format. --------------030407060303070106060806 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 843 Hi Daniel, Daniel Jacobowitz schrieb: > On Mon, Jan 28, 2008 at 03:46:02PM +0100, Markus Deuling wrote: > Yes, this looks like a bug. It is caused by the special case in > mips_gdbarch_init, by the comment: > > /* Try the architecture for any hint of the correct ABI. */ > > I think replacing the internal error by "return" or "break" would be > safe. No real Linux application will ever have the EABI32 or EABI64 > ABIs. sorry for the late response. This patch simply removes the internal error. Maybe it would be a good idea to add a warning instead? But as you say no Linux application will ever run into this so the warning might be unnecessary. Is this patch ok? ChangeLog: * mips-linux-tdep.c (mips_linux_init_abi): Remove internal error. -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com --------------030407060303070106060806 Content-Type: text/plain; name="fix-mips" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="fix-mips" Content-length: 434 diff -urpN src/gdb/mips-linux-tdep.c dev/gdb/mips-linux-tdep.c --- src/gdb/mips-linux-tdep.c 2008-01-01 23:53:12.000000000 +0100 +++ dev/gdb/mips-linux-tdep.c 2008-02-14 06:54:39.000000000 +0100 @@ -1149,7 +1149,6 @@ mips_linux_init_abi (struct gdbarch_info tramp_frame_prepend_unwinder (gdbarch, &mips_linux_n64_rt_sigframe); break; default: - internal_error (__FILE__, __LINE__, _("can't handle ABI")); break; } --------------030407060303070106060806--