Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Markus Deuling <deuling@de.ibm.com>
To: Maxim Grigoriev <maxim@tensilica.com>
Cc: gdb-patches@sources.redhat.com,
	Marc Gauthier <marc@tensilica.com>,
	        Chris Zankel <czankel@tensilica.com>,
	        Bob Wilson <bwilson@tensilica.com>
Subject: Re: [commit] Adding support for Xtensa GNU/Linux
Date: Wed, 13 Feb 2008 07:16:00 -0000	[thread overview]
Message-ID: <47B298C5.9030001@de.ibm.com> (raw)
In-Reply-To: <47B0C695.7010908@hq.tensilica.com>

[-- Attachment #1: Type: text/plain, Size: 908 bytes --]

Hi Maxim,

Maxim Grigoriev schrieb:
> This patch adds support for Xtensa GNU/Linux.
> 
> We like XML approach to describe register files. It matches
> Xtensa, which requires register files to be easily configurable.
> 
> But, we need more time to update Xtensa FSF GDB/GDBSERVER
> to start fully using this feature. So this version of Xtensa
> FSF GDB/GDBSERVER does not use this new approach.
> 

there is a problem in your patch that breaks GDB's build if you build with enable-targets=all.

xtensa-linux-nat.o is part of ALL_TARGET_OBS which are built when using enable-targets=all. If you now build GDB
for example on x86 you have two native files (the one from x86 and always xtensa-linux-nat).

This patch fixes that. Ok to commit?

ChangeLog:

	* Makefile.in (ALL_TARGET_OBS): Remove dependency to xtensa-linux-nat.o.



-- 
  Markus Deuling
  GNU Toolchain for Linux on Cell BE
  deuling@de.ibm.com


[-- Attachment #2: fix-xtensa --]
[-- Type: text/plain, Size: 482 bytes --]

diff -urpN src/gdb/Makefile.in dev/gdb/Makefile.in
--- src/gdb/Makefile.in	2008-02-12 05:50:17.000000000 +0100
+++ dev/gdb/Makefile.in	2008-02-13 08:12:06.000000000 +0100
@@ -479,7 +479,7 @@ ALL_TARGET_OBS = \
 	v850-tdep.o \
 	vaxnbsd-tdep.o vaxobsd-tdep.o vax-tdep.o \
 	xstormy16-tdep.o \
-	xtensa-config.o xtensa-tdep.o xtensa-linux-nat.o xtensa-linux-tdep.o \
+	xtensa-config.o xtensa-tdep.o xtensa-linux-tdep.o \
 	glibc-tdep.o \
 	bsd-uthread.o \
 	nbsd-tdep.o obsd-tdep.o \

  reply	other threads:[~2008-02-13  7:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-11 22:05 Maxim Grigoriev
2008-02-13  7:16 ` Markus Deuling [this message]
2008-02-13 13:38   ` Daniel Jacobowitz
2008-02-14  4:50     ` Markus Deuling
2008-02-13 18:12   ` Maxim Grigoriev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47B298C5.9030001@de.ibm.com \
    --to=deuling@de.ibm.com \
    --cc=bwilson@tensilica.com \
    --cc=czankel@tensilica.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=marc@tensilica.com \
    --cc=maxim@tensilica.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox