Re: [patch] Do not add partial_symbol again and again to the list

Aleksandar Ristovski
2008-02-11T21:41:44Z

> On Mon, Feb 11, 2008 at 03:51:59PM -0500, Aleksandar Ristovski wrote:
>> Daniel Jacobowitz wrote:
>>> On Mon, Feb 11, 2008 at 03:23:35PM -0500, Aleksandar Ristovski wrote:
>>>> The attached patch checks if partial_symbol has already been added to
>>>> the list instead of adding duplicate records.
>>> How does this ever happen? It seems very wrong. Also, I am worried
>>> that the linear search will be a bottleneck (this is quadratic as each
>>> psymtab grows).
>> Yes, I understand your concern about the complexity... but...
>
> That's only part of the problem. You have this huge duplication of
> identical partial symbols within the same block. How did that happen?
> It shouldn't. Maybe we can avoid creating them in the first place.
>
Daniel, could you clarify: when you say "maybe we can avoid..." who is "we" -
gdb or gcc?