Re: [patch] Do not add partial_symbol again and again to the list

Daniel Jacobowitz
2008-06-05T18:17:02Z

On Tue, May 06, 2008 at 03:24:34PM -0400, Aleksandar Ristovski wrote:
> Daniel Jacobowitz wrote:
>>
>> I think we should finish up this patch, and then proceed from there.
>>
>> Should we use this optimization for all global psymtabs? If so, then
>> we ought to do it in common code so that all the other symbol readers,
>> like stabs, benefit.
>>
>
> Ok, here is simplified, but with broader consequences patch.
>
> The patch now affects all readers that use add_psymbol_to_list by not
> allowing duplicate partial symbols in the global psymbol list (for a given
> objfile).
>
> Tested on linux dwarf2 format, no regression. I did
> not test other debug formats.

This is OK if you'll rename bcache_added to deprecated_bcache_added,
as we discussed before. I think it'll work fine.

> +void *
> +bcache_added (const void *addr, int length, struct bcache *bcache,
> + int *added)

Wrong indentation there?

--
Daniel Jacobowitz
CodeSourcery