Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Aleksandar Ristovski <aristovski@qnx.com>
To: Doug Evans <dje@google.com>
Cc: Daniel Jacobowitz <drow@false.org>, gdb-patches@sourceware.org
Subject: Re: [patch] make --disable-gdbmi work
Date: Fri, 01 Feb 2008 19:06:00 -0000	[thread overview]
Message-ID: <47A36DA3.2080804@qnx.com> (raw)
In-Reply-To: <e394668d0802010939p7ad83362j1b5a43541e9fb57b@mail.gmail.com>

Doug Evans wrote:
> On Jan 31, 2008 1:01 PM, Aleksandar Ristovski <aristovski@qnx.com> wrote:
>> Daniel Jacobowitz wrote:
>>> On Thu, Jan 31, 2008 at 03:50:27PM -0500, Aleksandar Ristovski wrote:
>>>> The attached patch fixes the problem.
>>> My opinion is that we don't want this functionality any more.  MI used
>>> to be optional, but it is a central part of GDB nowadays, and
>>> conditional compilation is hard to maintain.
>>>
>> It certainly adds some effort to maintenance, but it's not as bad as it may
>> sound, especially since the change is not extensive at all (see the patch).
>>
>> For embedded systems, it is important to have as small a binary as possible, and
>> if we can reduce it with reasonable effort, I would say, why not?
> 
> [fwiw]
> 
> The patch appeals to the minimalist side in me.  And given its trivial
> nature, it could go in without formally committing to the intended
> goal.  If later things get unwieldy we can revisit whether to support
> minimal builds then.
> 
> btw, do we have automated builds+tests for gdb?
> 

Yes, Vladimir correctly pointed out - my argument about reducing the code size 
is not really a good one...

I still think the patch is useful, if for no other reason, to keep dependencies 
single directional (mi -> gdb).


  reply	other threads:[~2008-02-01 19:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-31 21:01 Aleksandar Ristovski
2008-01-31 21:08 ` Daniel Jacobowitz
2008-01-31 21:49   ` Aleksandar Ristovski
2008-02-01 17:40     ` Doug Evans
2008-02-01 19:06       ` Aleksandar Ristovski [this message]
2008-02-01 19:19         ` Daniel Jacobowitz
2008-02-01 19:28           ` Aleksandar Ristovski
2008-02-01 19:20       ` Daniel Jacobowitz
2008-02-01 17:48     ` Vladimir Prus
2008-02-01 12:39 ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47A36DA3.2080804@qnx.com \
    --to=aristovski@qnx.com \
    --cc=dje@google.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox