Ulrich Weigand wrote:
> Aleksandar Ristovski wrote:
> 
>> Nto target has been maintained in our private branch and hasn't been
>> synchronized with mainstream for a while.
>> As a result, nto target does not compile. This patch brings it up-to 
>> date.
> 
> Thank you very much for working on getting nto support in GDB mainline
> up to date.  Unfortunately, this patch introduces a number of coding
> style violations that I'd ask you to fix before this can be applied.
> 
> Also, the patch introduces a number of functions and macros that are
> apparently not used anywhere, neither in the patch nor in the existing
> nto code.  Is this something to support some other out-of-mainline code?
> It would be better if we only add functions as they are actually needed
> in mainline.
> 
Hello Ulrich,

Sorry for the long delay. I have cleaned up the code and am resubmitting the patch.


Please review.

Thank you,
Aleksandar


2008-01-25  Aleksandar Ristovski  <aristovski@qnx.com>

	* Makefile.in (nto_tdep_h, i386-nto-tdep.o, nto-tdep.o): Added
	dependency.
	* nto.mh (NAT_FILE): Removed.
	* nm-nto.h: Removed file.
	* nto-procfs.c (procfs_xfer_memory): Changed argument type.
	(notice_signals): Removed function.
	(procfs_notice_signals): New function.
	(procfs_thread_alive): Changed to use DCMD_PROC_TIDSTATUS and
	properly interpret thread's status.
	(procfs_wait): Print error if sigwaitinfo fails. Get status properly
	(ufltset): New union, to workaround aliasing rules violation
	warnings in newer gcc versions.
	(procfs_resume): Use union ufltset to workaround aliasing rules
	violation, call new function procfs_notice_signals instead of
	notice_signals. Added new case for the inferior's status when
	we want to pass signal. Comments formatting.
	* nto-tdep.c: New includes. Removed hard-coded default target path.
	(nto_set_target): Use new nto_generic_svr4_fetch_link_map_offsets
	functions unless overriden.
	(PATH_FMT): Reformat macro to fit in.
	(nto_find_and_open_solib): Make sure not to dereference NULL ptr.
	(nto_init_solib_absolute_prefix): Add set solib-search-path.
	(nto_parse_redirection): Changed argument type.
	(nto_generic_svr4_fetch_link_map_offsets): New function.
	(LM_ADDR, LM_ADDR_FROM_LINK_MAP): Renamed.
	(nto_relocate_section_addresses): Use LM_ADDR_FROM_LINK_MAP.
	(nto_target_extra_thread_info): New function.
	(nto_initialize_signals): Make sure signals are correct in case
	host is different from the target.
	(show_nto_debug): New function.
	(nto_print_tidinfo_callback): New function.
	(nto_info_tidinfo_command): New function.
	* nto-tdep.h: New include.
	(private_thread_info): New struct for extra thread information.
	(nto_parse_redirection): Changed argument type.
	(nto_target_extra_thread_info): New declaration.
	(nto_generic_svr4_fetch_link_map_offsets): New declaration.