Re: arm_addr_bits_remove

Pedro Alves
2008-01-24T12:41:41Z

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

Jim Blandy wrote:
> On Jan 23, 2008 8:53 PM, Pedro Alves wrote:
>> Would a patch removing this be more acceptable then?
>
> I'd certainly be more enthusiastic about it. :)
>

Well, then, here's one for the review-enthusiasts amongst us. :-)

Thanks Jim.

OK ?

--
Pedro Alves

[-- Attachment #2: record_line.diff --]
[-- Type: text/x-diff, Size: 802 bytes --]

2008-01-24 Pedro Alves <pedro@codesourcery.com>

* buildsym.c (record_line): Don't try to strip unused addr bits.

---
gdb/buildsym.c | 2 --
1 files changed, 2 deletions(-)

Index: gdb-trunk/gdb/buildsym.c
===================================================================
--- gdb-trunk.orig/gdb/buildsym.c 2008-01-09 10:53:49.000000000 -0800
+++ gdb-trunk/gdb/buildsym.c 2008-01-24 04:30:26.000000000 -0800
@@ -794,8 +794,6 @@ record_line (struct subfile *subfile, in
* sizeof (struct linetable_entry))));
}

- pc = gdbarch_addr_bits_remove (current_gdbarch, pc);
-
/* Normally, we treat lines as unsorted. But the end of sequence
marker is special. We sort line markers at the same PC by line
number, so end of sequence markers (which have line == 0) appear