From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15105 invoked by alias); 24 Jan 2008 23:50:45 -0000 Received: (qmail 15096 invoked by uid 22791); 24 Jan 2008 23:50:45 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 24 Jan 2008 23:50:26 +0000 Received: (qmail 2473 invoked from network); 24 Jan 2008 23:50:18 -0000 Received: from unknown (HELO ?192.168.0.100?) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 24 Jan 2008 23:50:18 -0000 Message-ID: <47992419.1070201@codesourcery.com> Date: Fri, 25 Jan 2008 00:11:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.13pre) Gecko/20071023 Thunderbird/1.5.0.14pre Mnenhy/0.7.5.0 MIME-Version: 1.0 To: Joel Brobecker CC: Jim Blandy , gdb-patches Subject: Re: arm_addr_bits_remove References: <47965D31.3040602@codesourcery.com> <8f2776cb0801221525w1d26661dgf6452f876197a591@mail.gmail.com> <479752C8.8030201@portugalmail.pt> <8f2776cb0801231121r3fe9aea0q6f3c3d6887fcb251@mail.gmail.com> <20080123192842.GA22477@caradoc.them.org> <8f2776cb0801231311o19c31781h8a4663c405bcd22b@mail.gmail.com> <479819E2.1030603@portugalmail.pt> <8f2776cb0801232227n64502d4akef4642b051e77772@mail.gmail.com> <4798871B.4080207@codesourcery.com> <20080124133844.GA15771@caradoc.them.org> <20080124214849.GF3979@adacore.com> In-Reply-To: <20080124214849.GF3979@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00598.txt.bz2 Joel Brobecker wrote: > I just ran the testsuite on hppa and mips-irix, no regression. > It might not come as a surprise given that the patch is removing > something that handles what amounts to incorrect debugging info, > but it's better than nothing. In both case, we use GNU and the > system linker. > For the record: hppa-tdep.c has this function registered as gdbarch_addr_bits_remove: static CORE_ADDR hppa_smash_text_address (CORE_ADDR addr) { /* The low two bits of the PC on the PA contain the privilege level. Some genius implementing a (non-GCC) compiler apparently decided this means that "addresses" in a text section therefore include a privilege level, and thus symbol tables should contain these bits. This seems like a bonehead thing to do--anyway, it seems to work for our purposes to just ignore those bits. */ return (addr &= ~0x3); } I guess that compiler would be HP's. If the symbols had the bits set, so could the line info. Do we still support HP's object format and debug info ? I see that the hppa port of gas has this .export pseudo that enable the setting of a privilege level (priv_lev in c-hppa.texi). It doesn't seem to be covered by gdb's testsuite in testsuite/gdb.hp. -- Pedro Alves