From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16101 invoked by alias); 24 Jan 2008 04:54:30 -0000 Received: (qmail 16093 invoked by uid 22791); 24 Jan 2008 04:54:29 -0000 X-Spam-Check-By: sourceware.org Received: from ug-out-1314.google.com (HELO ug-out-1314.google.com) (66.249.92.173) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 24 Jan 2008 04:54:01 +0000 Received: by ug-out-1314.google.com with SMTP id h2so574524ugf.12 for ; Wed, 23 Jan 2008 20:53:58 -0800 (PST) Received: by 10.67.116.11 with SMTP id t11mr1786662ugm.61.1201150437749; Wed, 23 Jan 2008 20:53:57 -0800 (PST) Received: from ?192.168.0.100? ( [85.241.1.216]) by mx.google.com with ESMTPS id p10sm295911gvf.8.2008.01.23.20.53.55 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 23 Jan 2008 20:53:56 -0800 (PST) Message-ID: <479819E2.1030603@portugalmail.pt> Date: Thu, 24 Jan 2008 04:54:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.13pre) Gecko/20071023 Thunderbird/1.5.0.14pre Mnenhy/0.7.5.0 MIME-Version: 1.0 To: Jim Blandy CC: gdb-patches Subject: Re: arm_addr_bits_remove References: <47965D31.3040602@codesourcery.com> <8f2776cb0801221525w1d26661dgf6452f876197a591@mail.gmail.com> <479752C8.8030201@portugalmail.pt> <8f2776cb0801231121r3fe9aea0q6f3c3d6887fcb251@mail.gmail.com> <20080123192842.GA22477@caradoc.them.org> <8f2776cb0801231311o19c31781h8a4663c405bcd22b@mail.gmail.com> In-Reply-To: <8f2776cb0801231311o19c31781h8a4663c405bcd22b@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00577.txt.bz2 Jim Blandy wrote: > On Jan 23, 2008 11:28 AM, Daniel Jacobowitz wrote: >> It was for Thumb in the first place. >> >> http://sourceware.org/ml/gdb-patches/2001-03/msg00182.html >> http://sourceware.org/ml/gdb-patches/2001-04/msg00012.html >> >> That may not be true on new toolchains though. > > Rats. If it'd be quick for you to check current toolchains, could you? > Jim Blandy wrote: > 2001-04-06 Fernando Nasser > > * buildsym.c (record_line): Turn off unused addr bits. > > Could we try simply removing this? > Removing this shows no regressions on arm-eabi or arm-linux-gnueabi. I've also ran the testsuite on arm-linux-gnueabi arm/thumb replacing the stripping in record_line by logging the pc being stripped, and no odd address was ever printed. Would a patch removing this be more acceptable then? -- Pedro Alves