From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32755 invoked by alias); 17 Jan 2008 09:20:41 -0000 Received: (qmail 32744 invoked by uid 22791); 17 Jan 2008 09:20:40 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 17 Jan 2008 09:20:18 +0000 Received: from d12nrmr1507.megacenter.de.ibm.com (d12nrmr1507.megacenter.de.ibm.com [9.149.167.1]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id m0H9KE0E409576 for ; Thu, 17 Jan 2008 09:20:14 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1507.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m0H9JsCE1798300 for ; Thu, 17 Jan 2008 10:20:04 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m0H9IiNA016250 for ; Thu, 17 Jan 2008 10:18:44 +0100 Received: from bbkeks.de.ibm.com (dyn-9-152-248-46.boeblingen.de.ibm.com [9.152.248.46]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m0H9IaeY014529 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 17 Jan 2008 10:18:44 +0100 Message-ID: <478F1CC5.904@de.ibm.com> Date: Thu, 17 Jan 2008 09:20:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.9 (X11/20071031) MIME-Version: 1.0 To: GDB Patches CC: Ulrich Weigand Subject: [rfc] Remove default_gcore_mach from gcore.c Content-Type: multipart/mixed; boundary="------------010901020301010502040603" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00433.txt.bz2 This is a multi-part message in MIME format. --------------010901020301010502040603 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Content-length: 347 Hi, this patch remvoes default_gcore_mach as it seems to be useless (always returns 0). I tested it on x86 and testsuite showed no regressions. What do you think? Is this funtion still useful? Ok to commit? ChangeLog: * gcore.c (default_gcore_mach): Remove. -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com --------------010901020301010502040603 Content-Type: text/plain; name="diff-gcore" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diff-gcore" Content-length: 1317 diff -urpN src/gdb/gcore.c dev/gdb/gcore.c --- src/gdb/gcore.c 2008-01-01 23:53:09.000000000 +0100 +++ dev/gdb/gcore.c 2008-01-17 09:38:48.000000000 +0100 @@ -37,7 +37,6 @@ static char *default_gcore_target (void); static enum bfd_architecture default_gcore_arch (void); -static unsigned long default_gcore_mach (void); static int gcore_memory_sections (bfd *); /* Generate a core file from the inferior process. */ @@ -78,7 +77,6 @@ gcore_command (char *args, int from_tty) old_chain = make_cleanup_bfd_close (obfd); bfd_set_format (obfd, bfd_core); - bfd_set_arch_mach (obfd, default_gcore_arch (), default_gcore_mach ()); /* An external target method must build the notes section. */ note_data = target_make_corefile_notes (obfd, ¬e_size); @@ -118,24 +116,6 @@ gcore_command (char *args, int from_tty) return; } -static unsigned long -default_gcore_mach (void) -{ -#if 1 /* See if this even matters... */ - return 0; -#else - - const struct bfd_arch_info *bfdarch = gdbarch_bfd_arch_info (current_gdbarch); - - if (bfdarch != NULL) - return bfdarch->mach; - if (exec_bfd == NULL) - error (_("Can't find default bfd machine type (need execfile).")); - - return bfd_get_mach (exec_bfd); -#endif /* 1 */ -} - static enum bfd_architecture default_gcore_arch (void) { --------------010901020301010502040603--