From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24704 invoked by alias); 17 Jan 2008 07:09:07 -0000 Received: (qmail 24677 invoked by uid 22791); 17 Jan 2008 07:09:04 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 17 Jan 2008 07:08:42 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.13.8/8.13.8) with ESMTP id m0H78d8I195480 for ; Thu, 17 Jan 2008 07:08:39 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m0H78dtB2789522 for ; Thu, 17 Jan 2008 08:08:39 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m0H78chs013775 for ; Thu, 17 Jan 2008 08:08:39 +0100 Received: from bbkeks.de.ibm.com (dyn-9-152-248-46.boeblingen.de.ibm.com [9.152.248.46]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m0H78civ013764 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 17 Jan 2008 08:08:38 +0100 Message-ID: <478EFE86.1060006@de.ibm.com> Date: Thu, 17 Jan 2008 07:09:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.9 (X11/20071031) MIME-Version: 1.0 To: Eli Zaretskii CC: uweigand@de.ibm.com, gdb-patches@sourceware.org, drow@false.org Subject: Re: [patch] Remove BITS_BIG_ENDIAN from defs.h References: <200801152101.m0FL12x2012798@d12av02.megacenter.de.ibm.com> <478D9CB1.3060905@de.ibm.com> In-Reply-To: Content-Type: multipart/mixed; boundary="------------010408090001000809050004" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00431.txt.bz2 This is a multi-part message in MIME format. --------------010408090001000809050004 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1620 Eli Zaretskii schrieb: >> Date: Wed, 16 Jan 2008 06:57:05 +0100 >> From: Markus Deuling >> CC: GDB Patches , Eli Zaretskii , >> Daniel Jacobowitz >> >> Eli, is the documentation ok like this ? > > I have a few comments: > >> ChangeLog Doc: >> >> * gdbint.texinfo (BITS_BIG_ENDIAN): Rewrite to match >> gdbarch_bits_big_endian. > > Actually, this should say something like: > > * gdbint.texinfo (Target Conditionals): Replace the > description of BITS_BIG_ENDIAN with a description of > gdbarch_bits_big_endian. > > Note that the text in parens is the name of the node in which you make > the change. > >> +@item gdbarch_bits_big_endian (@var{gdbarch}) >> +@findex gdbarch_bits_big_endian >> +Set this if the numbering of bits in the targets does @strong{not} match the > > "Set this" isn't right, because you don't "set" a function. I think > it's better to say "Define this to return non-zero it bits are > numbered in the big-endian order (i.e., the rightmost bit has the > largest number), zero otherwise." > > Btw, should we also document set_gdbarch_bits_big_endian? > Hi Eli, thank you very much for your review. I reworked the patch and added an entry for set_gdbarch_bits_big_endian. I also added it to the Target Conditionals node. Is that right? Is this ok ? ChangeLog: * gdbint.texinfo (Target Conditionals): Replace the description of BITS_BIG_ENDIAN with a description of gdbarch_bits_big_endian. Regards, Markus -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com --------------010408090001000809050004 Content-Type: text/plain; name="diff-doc-ENDIAN" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diff-doc-ENDIAN" Content-length: 1270 diff -urpN src/gdb/doc/gdbint.texinfo dev/gdb/doc/gdbint.texinfo --- src/gdb/doc/gdbint.texinfo 2008-01-05 17:49:53.000000000 +0100 +++ dev/gdb/doc/gdbint.texinfo 2008-01-17 07:57:10.000000000 +0100 @@ -3344,12 +3344,19 @@ Used to notify if the compiler promotes parameter to an @code{int}, but still reports the parameter as its original type, rather than the promoted type. -@item BITS_BIG_ENDIAN -@findex BITS_BIG_ENDIAN -Define this if the numbering of bits in the targets does @strong{not} match the -endianness of the target byte order. A value of 1 means that the bits +@item gdbarch_bits_big_endian (@var{gdbarch}) +@findex gdbarch_bits_big_endian +This is used if the numbering of bits in the targets does @strong{not} match +the endianness of the target byte order. A value of 1 means that the bits are numbered in a big-endian bit order, 0 means little-endian. +@item set_gdbarch_bits_big_endian (@var{gdbarch}, @var{bits_big_endian}) +@findex set_gdbarch_bits_big_endian +Calling set_gdbarch_bits_big_endian with a value of 1 indicates that the +bits in the target are numbered in a big-endian bit order, 0 indicates +little-endian. + + @item BREAKPOINT @findex BREAKPOINT This is the character array initializer for the bit pattern to put into --------------010408090001000809050004--