Andreas Schwab schrieb:
> Markus Deuling <deuling@de.ibm.com> writes:
> 
>> diff -urpN src/gdb/coffread.c dev/gdb/coffread.c
>> --- src/gdb/coffread.c	2008-01-01 23:53:09.000000000 +0100
>> +++ dev/gdb/coffread.c	2008-01-16 09:48:28.000000000 +0100
>> @@ -198,7 +198,7 @@ coff_locate_sections (bfd *abfd, asectio
>>  
>>    csi = (struct coff_symfile_info *) csip;
>>    name = bfd_get_section_name (abfd, sectp);
>> -  if (DEPRECATED_STREQ (name, ".text"))
>> +  if (!strcmp (name, ".text"))
> 
> I think you should generally use strcmp (...) == 0, since the return
> value is not a boolean.


Mark Kettenis schrieb:
>> this patch replaces and removes DEPRECATED_STREQ. Tested on x86 and
>> PowerPC without regression. Is this ok to commit ?
> 
> Please, please, use
> 
>     if (strcmp(a, b) == 0)
> 
> instead of
> 
>     if (!strcmp(a, b))
> 
> I always read the latter as exactly the opposite of what it really
> means, and the former is the prevalent way of coding this everywhere
> else in GDB.


Ok, ok :-) I agree strcmp (a,b) == 0 is much more readable. I reworked the patch now.

Ok to commit?


Regards, 
Markus

-- 
  Markus Deuling
  GNU Toolchain for Linux on Cell BE
  deuling@de.ibm.com